Bug 156161 - Add missing EABI_32BIT_DUMMY_ARG arguments for some callOperation(J_JITOperation_EGReoJ, ...) overloads
Summary: Add missing EABI_32BIT_DUMMY_ARG arguments for some callOperation(J_JITOperat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-04 02:16 PDT by Zan Dobersek
Modified: 2016-04-05 00:59 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.61 KB, patch)
2016-04-04 02:27 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2016-04-04 02:16:10 PDT 
Add missing EABI_32BIT_DUMMY_ARG arguments for some callOperation(J_JITOperation_EGReoJ, ...) overloads
Comment 1 Zan Dobersek 2016-04-04 02:27:03 PDT 
Created attachment 275542 [details]
Patch
Comment 2 Yusuke Suzuki 2016-04-04 05:10:34 PDT 
Comment on attachment 275542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275542&action=review

Nice catch!

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1742
> +        m_jit.setupArgumentsWithExecState(arg1, arg2, EABI_32BIT_DUMMY_ARG arg3Payload, arg3Tag);

Is SH4_32BIT_DUMMY_ARG necessary here too?
(BTW, at a glance, there are several missing SH4_32BIT_DUMMY_ARG. I'm not sure there are any active users of SH4 port...)

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1854
> +        m_jit.setupArgumentsWithExecState(arg1, arg2, EABI_32BIT_DUMMY_ARG arg3Payload, arg3Tag);

Ditto.
Comment 3 Zan Dobersek 2016-04-04 23:29:25 PDT 
Comment on attachment 275542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275542&action=review

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1742
>> +        m_jit.setupArgumentsWithExecState(arg1, arg2, EABI_32BIT_DUMMY_ARG arg3Payload, arg3Tag);
> 
> Is SH4_32BIT_DUMMY_ARG necessary here too?
> (BTW, at a glance, there are several missing SH4_32BIT_DUMMY_ARG. I'm not sure there are any active users of SH4 port...)

I don't know. The comment for SH4_32BIT_DUMMY_ARG suggests yes, but in that case there are a lot of these dummy args missing already, and I'm not aware of any public builder testing for this configuration. Not being able to test on this platform makes me reluctant to try and put args into the proper places.
Comment 4 Zan Dobersek 2016-04-04 23:30:07 PDT 
Comment on attachment 275542 [details]
Patch

Clearing flags on attachment: 275542

Committed r199052: <http://trac.webkit.org/changeset/199052>
Comment 5 Zan Dobersek 2016-04-04 23:30:16 PDT 
All reviewed patches have been landed.  Closing bug.