Bug 156158 - [TexMap] resolveOverlaps() should be passed-in the first Region parameter via a reference
Summary: [TexMap] resolveOverlaps() should be passed-in the first Region parameter via...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-04 01:24 PDT by Zan Dobersek
Modified: 2016-04-04 23:09 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.82 KB, patch)
2016-04-04 01:29 PDT, Zan Dobersek
tonikitoo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2016-04-04 01:24:18 PDT
[TexMap] resolveOverlaps() should be passed-in the first Region parameter via a reference
Comment 1 Zan Dobersek 2016-04-04 01:29:03 PDT
Created attachment 275535 [details]
Patch
Comment 2 Antonio Gomes 2016-04-04 07:03:36 PDT
Comment on attachment 275535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275535&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:241
> +static void resolveOverlaps(Region& newRegion, Region& overlapRegion, Region& nonOverlapRegion)

It does not look like the modified 'newRegion' value is used in the callee site, but it avoid one copy, ok.
Comment 3 Zan Dobersek 2016-04-04 23:09:06 PDT
Committed r199044: <http://trac.webkit.org/changeset/199044>