Bug 156156 - Enable assertions against DOM mutations in RenderTreeUpdater
Summary: Enable assertions against DOM mutations in RenderTreeUpdater
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-04 00:10 PDT by Antti Koivisto
Modified: 2016-04-04 06:09 PDT (History)
0 users

See Also:

Attachments
patch (16.29 KB, patch)
2016-04-04 01:12 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
patch (16.49 KB, patch)
2016-04-04 01:22 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (16.53 KB, patch)
2016-04-04 01:51 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-04-04 00:10:48 PDT 
Ensure we don't mutate DOM or dispatch events during render tree updates.
Comment 1 Antti Koivisto 2016-04-04 01:12:08 PDT 
Created attachment 275532 [details]
patch
Comment 2 Andreas Kling 2016-04-04 01:19:46 PDT 
Comment on attachment 275532 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275532&action=review

r=me

> Source/WebCore/loader/cache/CachedSVGFont.cpp:69
> +        auto count = NoEventDispatchAssertion::dropTemporarily();

If we plan to do more of this, maybe a RAII helper would be in good taste.
Comment 3 Antti Koivisto 2016-04-04 01:22:23 PDT 
Created attachment 275534 [details]
patch
Comment 4 Antti Koivisto 2016-04-04 01:51:13 PDT 
Created attachment 275537 [details]
patch
Comment 5 Antti Koivisto 2016-04-04 06:09:29 PDT 
https://trac.webkit.org/r199003