Bug 156153 - Add SPI to allow install script message handlers in isolated worlds
Summary: Add SPI to allow install script message handlers in isolated worlds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-03 22:17 PDT by Sam Weinig
Modified: 2016-04-04 16:40 PDT (History)
8 users (show)

See Also:


Attachments
Patch (66.35 KB, patch)
2016-04-03 22:37 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2016-04-03 22:17:04 PDT
Add SPI to allow install script message handlers in isolated worlds
Comment 1 Sam Weinig 2016-04-03 22:37:46 PDT
Created attachment 275530 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-03 22:39:40 PDT
Attachment 275530 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/UserContent/WebScriptMessageHandler.h:40:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:310:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:132:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:133:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:134:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:135:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:136:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:137:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:137:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 10 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2016-04-04 09:46:11 PDT
Comment on attachment 275530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275530&action=review

> Source/WebCore/page/UserMessageHandlersNamespace.cpp:53
> +    decltype(m_messageHandlers) oldMap = WTFMove(m_messageHandlers);

auto oldMap =

> Source/WebKit2/UIProcess/UserContent/WebScriptMessageHandler.h:40
> +    class UserContentWorld;

Don't indent this.
Comment 4 Sam Weinig 2016-04-04 14:03:21 PDT
Committed r199020: <http://trac.webkit.org/changeset/199020>