Add SPI to allow install script message handlers in isolated worlds
Created attachment 275530 [details] Patch
Attachment 275530 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/UserContent/WebScriptMessageHandler.h:40: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:310: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:135: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:137: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 10 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 275530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275530&action=review > Source/WebCore/page/UserMessageHandlersNamespace.cpp:53 > + decltype(m_messageHandlers) oldMap = WTFMove(m_messageHandlers); auto oldMap = > Source/WebKit2/UIProcess/UserContent/WebScriptMessageHandler.h:40 > + class UserContentWorld; Don't indent this.
Committed r199020: <http://trac.webkit.org/changeset/199020>
(In reply to comment #4) > Committed r199020: <http://trac.webkit.org/changeset/199020> This broke the GTK+ build: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/68074/steps/compile-webkit/logs/stdio/text