RESOLVED FIXED 156151
prepare-ChangeLog set endl incorrectly 
https://bugs.webkit.org/show_bug.cgi?id=156151
Summary prepare-ChangeLog set endl incorrectly
Bill Ming
Reported 2016-04-03 17:06:41 PDT
prepare-Changelog tried to detect line endings based on the target file format, normally the ChangeLog file is in unix ('\n') line endings, and the perl script will prepare content with each line appended with a '\n', but when writing to the file, perl will try to convert line endings with the platform's native line endings and result in changing the whole file into dos format. setting the binmode can fix this issue.
Attachments
Patch (1.28 KB, patch)
2016-04-03 17:09 PDT, Bill Ming 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bill Ming
Comment 1 2016-04-03 17:09:26 PDT
Created attachment 275518 [details] Patch
WebKit Commit Bot
Comment 2 2016-04-04 15:54:26 PDT
Comment on attachment 275518 [details] Patch Clearing flags on attachment: 275518 Committed r199029: <http://trac.webkit.org/changeset/199029>
WebKit Commit Bot
Comment 3 2016-04-04 15:54:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.