RESOLVED FIXED 156150
[win] DumpRenderTree failed to launch 
https://bugs.webkit.org/show_bug.cgi?id=156150
Summary [win] DumpRenderTree failed to launch
Bill Ming
Reported 2016-04-03 16:36:15 PDT
DumpRenderTree failed to launch when I tried to run webkit tests. It's because WEBKIT_LIBRARIES environment is not included in 'env' passing to the launcher.
Attachments
Patch (1.09 KB, patch)
2016-04-03 16:39 PDT, Bill Ming 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bill Ming
Comment 1 2016-04-03 16:39:43 PDT
Created attachment 275517 [details] Patch
Alex Christensen
Comment 2 2016-04-04 14:58:20 PDT
Comment on attachment 275517 [details] Patch Hmmm, I'd like to get rid of our required use of the WEBKIT_LIBRARIES environment variable. Is there any way you could modify DLLLauncherMain.cpp instead to work without it?
Bill Ming
Comment 3 2016-04-04 15:12:49 PDT
I'm thinking of that too. That may need another bigger patch to completely get rid of the WEBKIT_LIBRARIES environment variable because the reference to it is not just limited to this. Shall I modify DLLLauncherMain.cpp for this patch first and then deal with other ones in another commit?
Alex Christensen
Comment 4 2016-04-04 15:14:08 PDT
We still want to use the WEBKIT_LIBRARIES environment variable if it exists, because the Windows Early Warning System bots use it, but I don't want to require it for someone to just build and run WebKit on a new machine.
Bill Ming
Comment 5 2016-04-04 15:19:05 PDT
So the logic should be like, if the environment exists, use it; if not, use a hard-coded path, am I right?
Bill Ming
Comment 6 2016-04-04 15:19:34 PDT
hard-coded relative path by the way.
Bill Ming
Comment 7 2016-04-04 16:31:38 PDT
After digging into the launcher code, I think it would be a little bit nasty to hard-code a relative path there. Either minibrowser.exe or dumprendertree.exe could be anywhere depend on user settings, so it doesn't make too much sense to put a 'default' dll path over there. Actually the 'default' path could also change, considering that user can say 'yes' or 'no' when asked by webkit-patch script if he would like to put all build results into a branch name folder
Alex Christensen
Comment 8 2016-04-04 20:03:47 PDT
Comment on attachment 275517 [details] Patch I guess this is good. If the WEBKIT_LIBRARIES variable is set, use it. That's what this patch does. Honestly, I usually copy all the WinCairoRequirements dlls into the build directory manually.
WebKit Commit Bot
Comment 9 2016-04-04 20:54:53 PDT
Comment on attachment 275517 [details] Patch Clearing flags on attachment: 275517 Committed r199036: <http://trac.webkit.org/changeset/199036>
WebKit Commit Bot
Comment 10 2016-04-04 20:54:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.