DumpRenderTree failed to launch when I tried to run webkit tests. It's because WEBKIT_LIBRARIES environment is not included in 'env' passing to the launcher.
Created attachment 275517 [details] Patch
Comment on attachment 275517 [details] Patch Hmmm, I'd like to get rid of our required use of the WEBKIT_LIBRARIES environment variable. Is there any way you could modify DLLLauncherMain.cpp instead to work without it?
I'm thinking of that too. That may need another bigger patch to completely get rid of the WEBKIT_LIBRARIES environment variable because the reference to it is not just limited to this. Shall I modify DLLLauncherMain.cpp for this patch first and then deal with other ones in another commit?
We still want to use the WEBKIT_LIBRARIES environment variable if it exists, because the Windows Early Warning System bots use it, but I don't want to require it for someone to just build and run WebKit on a new machine.
So the logic should be like, if the environment exists, use it; if not, use a hard-coded path, am I right?
hard-coded relative path by the way.
After digging into the launcher code, I think it would be a little bit nasty to hard-code a relative path there. Either minibrowser.exe or dumprendertree.exe could be anywhere depend on user settings, so it doesn't make too much sense to put a 'default' dll path over there. Actually the 'default' path could also change, considering that user can say 'yes' or 'no' when asked by webkit-patch script if he would like to put all build results into a branch name folder
Comment on attachment 275517 [details] Patch I guess this is good. If the WEBKIT_LIBRARIES variable is set, use it. That's what this patch does. Honestly, I usually copy all the WinCairoRequirements dlls into the build directory manually.
Comment on attachment 275517 [details] Patch Clearing flags on attachment: 275517 Committed r199036: <http://trac.webkit.org/changeset/199036>
All reviewed patches have been landed. Closing bug.