Bug 156150 - [win] DumpRenderTree failed to launch
Summary: [win] DumpRenderTree failed to launch
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2016-04-03 16:36 PDT by Bill Ming
Modified: 2016-04-04 20:54 PDT (History)
5 users (show)

See Also:

Patch (1.09 KB, patch)
2016-04-03 16:39 PDT, Bill Ming
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bill Ming 2016-04-03 16:36:15 PDT
DumpRenderTree failed to launch when I tried to run webkit tests.
It's because WEBKIT_LIBRARIES environment is not included in 'env' passing to the launcher.
Comment 1 Bill Ming 2016-04-03 16:39:43 PDT
Created attachment 275517 [details]
Comment 2 Alex Christensen 2016-04-04 14:58:20 PDT
Comment on attachment 275517 [details]

Hmmm, I'd like to get rid of our required use of the WEBKIT_LIBRARIES environment variable.  Is there any way you could modify DLLLauncherMain.cpp instead to work without it?
Comment 3 Bill Ming 2016-04-04 15:12:49 PDT
I'm thinking of that too. That may need another bigger patch to completely get rid of the WEBKIT_LIBRARIES environment variable because the reference to it is not just limited to this. Shall I modify DLLLauncherMain.cpp for this patch first and then deal with other ones in another commit?
Comment 4 Alex Christensen 2016-04-04 15:14:08 PDT
We still want to use the WEBKIT_LIBRARIES environment variable if it exists, because the Windows Early Warning System bots use it, but I don't want to require it for someone to just build and run WebKit on a new machine.
Comment 5 Bill Ming 2016-04-04 15:19:05 PDT
So the logic should be like, if the environment exists, use it; if not, use a hard-coded path, am I right?
Comment 6 Bill Ming 2016-04-04 15:19:34 PDT
hard-coded relative path by the way.
Comment 7 Bill Ming 2016-04-04 16:31:38 PDT
After digging into the launcher code, I think it would be a little bit nasty to hard-code a relative path there. Either minibrowser.exe or dumprendertree.exe could be anywhere depend on user settings, so it doesn't make too much sense to put a 'default' dll path over there. Actually the 'default' path could also change, considering that user can say 'yes' or 'no' when asked by webkit-patch script if he would like to put all build results into a branch name folder
Comment 8 Alex Christensen 2016-04-04 20:03:47 PDT
Comment on attachment 275517 [details]

I guess this is good.  If the WEBKIT_LIBRARIES variable is set, use it.  That's what this patch does.  Honestly, I usually copy all the WinCairoRequirements dlls into the build directory manually.
Comment 9 WebKit Commit Bot 2016-04-04 20:54:53 PDT
Comment on attachment 275517 [details]

Clearing flags on attachment: 275517

Committed r199036: <http://trac.webkit.org/changeset/199036>
Comment 10 WebKit Commit Bot 2016-04-04 20:54:57 PDT
All reviewed patches have been landed.  Closing bug.