Bug 156139 - Uncaught Exception: Error: Can't make a ContentView for an unknown representedObject (ApplicationCacheManifest)
Summary: Uncaught Exception: Error: Can't make a ContentView for an unknown represente...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: Mac OS X 10.11
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-02 14:52 PDT by Daniel Bates
Modified: 2016-04-04 22:20 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (5.06 KB, patch)
2016-04-04 16:58 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-04-02 14:52:57 PDT 
-------
Auto-generated details:

Inspected URL:        https://webkit.org/demos/sticky-notes/
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/602.1.27+ (KHTML, like Gecko)
Uncaught exceptions:
 - Error: Can't make a ContentView for an unknown representedObject. (at ContentView.js:149:86)
-------

* STEPS TO REPRODUCE
1. Visit <https://webkit.org/demos/sticky-notes/>.
2. Inspect the page.

I am using a release build of WebKit r198972.
Comment 1 Radar WebKit Bug Importer 2016-04-02 14:53:22 PDT 
<rdar://problem/25511926>
Comment 2 Joseph Pecoraro 2016-04-04 16:46:01 PDT 
I was able to reproduce. Improving the error message, I see two issues:

NavigationSidebarPanel.js:234:26: CONSOLE ERROR Error: TreeElement.representedObject is missing a saveIdentityToCookie implementation. TreeElement.constructor:  class ApplicationCacheManifestTreeElement extends WebInspector.StorageTreeElement

ContentView.js:149:132" CONSOLE ERROR Error: Can't make a ContentView for an unknown representedObject of type: ApplicationCacheManifest
Comment 3 Joseph Pecoraro 2016-04-04 16:58:06 PDT 
Created attachment 275593 [details]
[PATCH] Proposed Fix
Comment 4 Timothy Hatcher 2016-04-04 17:03:20 PDT 
Comment on attachment 275593 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=275593&action=review

> Source/WebInspectorUI/UserInterface/Views/ContentView.js:149
> +        throw new Error("Can't make a ContentView for an unknown representedObject of type: " + representedObject.constructor.name);

Good call!
Comment 5 WebKit Commit Bot 2016-04-04 22:20:38 PDT 
Comment on attachment 275593 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 275593

Committed r199041: <http://trac.webkit.org/changeset/199041>
Comment 6 WebKit Commit Bot 2016-04-04 22:20:42 PDT 
All reviewed patches have been landed.  Closing bug.