Bug 156124 - Web Inspector: Remove console.asserts from Worker code in optimized builds
Summary: Web Inspector: Remove console.asserts from Worker code in optimized builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-01 19:08 PDT by Joseph Pecoraro
Modified: 2016-04-01 22:41 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (6.02 KB, patch)
2016-04-01 19:10 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[TEXT] remove-console-asserts.pl (2.63 KB, text/x-perl-script)
2016-04-01 19:15 PDT, Joseph Pecoraro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-04-01 19:08:17 PDT 
* SUMMARY
Remove console.asserts from Worker code in optimized builds.
Comment 1 Radar WebKit Bug Importer 2016-04-01 19:08:42 PDT 
<rdar://problem/25505031>
Comment 2 Joseph Pecoraro 2016-04-01 19:10:25 PDT 
Created attachment 275455 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-04-01 19:15:34 PDT 
Created attachment 275456 [details]
[TEXT] remove-console-asserts.pl

Attached the file on its own because the diff looks horrible but the modifications are very small:

  - added a new --input-directory switch
  - moved the existing code into a function
  - use the functions for the different switches
Comment 4 WebKit Commit Bot 2016-04-01 22:23:30 PDT 
Comment on attachment 275455 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 275455

Committed r198968: <http://trac.webkit.org/changeset/198968>
Comment 5 WebKit Commit Bot 2016-04-01 22:23:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2016-04-01 22:41:28 PDT 
<http://trac.webkit.org/changeset/198969> Follow up to remove the debug print statement.