Bug 156102 - [JSC] Missing PATH_MAX definition
Summary: [JSC] Missing PATH_MAX definition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-01 02:38 PDT by Alberto Garcia
Modified: 2016-04-01 03:36 PDT (History)
9 users (show)

See Also:

Attachments
Patch (959 bytes, patch)
2016-04-01 02:40 PDT, Alberto Garcia 		ysuzuki: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2016-04-01 02:38:30 PDT 
Source/JavaScriptCore/jsc.cpp uses PATH_MAX on non-Windows platforms to get the current working directory, but that macro doesn't need to be defined if the system does not have that limit. This breaks the build in the Hurd, and possibly other systems.
Comment 1 Alberto Garcia 2016-04-01 02:40:38 PDT 
Created attachment 275392 [details]
Patch
Comment 2 Yusuke Suzuki 2016-04-01 02:59:02 PDT 
Comment on attachment 275392 [details]
Patch

adhoc way, but I think it's ok for jsc.cpp since it's just a harness.
Comment 3 Alberto Garcia 2016-04-01 03:34:25 PDT 
(In reply to comment #2)
> adhoc way, but I think it's ok for jsc.cpp since it's just a
> harness.

Right, I chose to do it like this because of that.

Thanks!
Comment 4 Alberto Garcia 2016-04-01 03:36:47 PDT 
Committed r198945: <http://trac.webkit.org/changeset/198945>