WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
156102
[JSC] Missing PATH_MAX definition
https://bugs.webkit.org/show_bug.cgi?id=156102
Summary
[JSC] Missing PATH_MAX definition
Alberto Garcia
Reported
2016-04-01 02:38:30 PDT
Source/JavaScriptCore/jsc.cpp uses PATH_MAX on non-Windows platforms to get the current working directory, but that macro doesn't need to be defined if the system does not have that limit. This breaks the build in the Hurd, and possibly other systems.
Attachments
Patch
(959 bytes, patch)
2016-04-01 02:40 PDT
,
Alberto Garcia
ysuzuki
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alberto Garcia
Comment 1
2016-04-01 02:40:38 PDT
Created
attachment 275392
[details]
Patch
Yusuke Suzuki
Comment 2
2016-04-01 02:59:02 PDT
Comment on
attachment 275392
[details]
Patch adhoc way, but I think it's ok for jsc.cpp since it's just a harness.
Alberto Garcia
Comment 3
2016-04-01 03:34:25 PDT
(In reply to
comment #2
)
> adhoc way, but I think it's ok for jsc.cpp since it's just a > harness.
Right, I chose to do it like this because of that. Thanks!
Alberto Garcia
Comment 4
2016-04-01 03:36:47 PDT
Committed
r198945
: <
http://trac.webkit.org/changeset/198945
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug