Bug 156085 - Web Inspector: ScriptSyntaxTree doesn't handle RestElement AST nodes
Summary: Web Inspector: ScriptSyntaxTree doesn't handle RestElement AST nodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-31 14:51 PDT by Joseph Pecoraro
Modified: 2016-03-31 15:50 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (17.01 KB, patch)
2016-03-31 14:57 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[IMAGE] After (89.08 KB, image/png)
2016-03-31 14:58 PDT, Joseph Pecoraro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-03-31 14:51:29 PDT 
* SUMMARY
ScriptSyntaxTree doesn't handle RestElement AST nodes.

This means it doesn't provide type bubbles for code which uses rest params.

* TEST
function foo(...things) {
    console.log(things);
}
Comment 1 Joseph Pecoraro 2016-03-31 14:57:29 PDT 
Created attachment 275333 [details]
[PATCH] Proposed Fix
Comment 2 Radar WebKit Bug Importer 2016-03-31 14:57:46 PDT 
<rdar://problem/25474604>
Comment 3 Joseph Pecoraro 2016-03-31 14:58:57 PDT 
Created attachment 275334 [details]
[IMAGE] After
Comment 4 Saam Barati 2016-03-31 14:59:18 PDT 
Comment on attachment 275333 [details]
[PATCH] Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2016-03-31 15:50:31 PDT 
Comment on attachment 275333 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 275333

Committed r198925: <http://trac.webkit.org/changeset/198925>
Comment 6 WebKit Commit Bot 2016-03-31 15:50:36 PDT 
All reviewed patches have been landed.  Closing bug.