Bug 156084 – AX: AX hit-testing does not work on WebKit video playback buttons

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Nan Wang]

We should allow hit testing on video tags.

[Nan Wang]

<rdar://problem/22536438>

[Nan Wang]

Created attachment 275350 [details]
initial patch

[Nan Wang]

Created attachment 275354 [details]
patch

test failed on DRT

[Darin Adler]

Comment on attachment 275354 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275354&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2260
> +    if (!shadowHost)
> +        return false;
> +    
> +    if (shadowHost->hasTagName(videoTag))
> +        return false;
> +    
> +    return true;

Cleaner way to write this:

    return shadowHost && shadowHost->hasTagName(videoTag);

But also, this needs a comment explaining why this is the correct implementation for this function. What is special about video tags?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2277
> +    Node* node = hitTestResult.innerNode();

Should put this into a local variable before the early return just above.

    Node* node = hitTestResult.innerNode();
    if (!node)
        return nullptr;

[Nan Wang]

Comment on attachment 275354 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275354&action=review

>> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2260
>> +    return true;
> 
> Cleaner way to write this:
> 
>     return shadowHost && shadowHost->hasTagName(videoTag);
> 
> But also, this needs a comment explaining why this is the correct implementation for this function. What is special about video tags?

We need to allow automation of mouse events on video tags.

[Nan Wang]

Committed r198941: <http://trac.webkit.org/changeset/198941>