rdar://problem/24922183
Created attachment 275314 [details] proposed fix
Comment on attachment 275314 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=275314&action=review r=me I would be ok with removing the dead code in this patch. > Source/WebCore/testing/MockPageOverlayClient.cpp:78 > + // FIXME: This is dead code, nothing ever calls this function. It's not clear to me what the intention was, Let's remove this, then!
Comment on attachment 275314 [details] proposed fix There is a lot more code to review, or possibly to fix. Out of scope for this patch.
Comment on attachment 275314 [details] proposed fix Clearing flags on attachment: 275314 Committed r198940: <http://trac.webkit.org/changeset/198940>
All reviewed patches have been landed. Closing bug.
To me, removing an unused function seems even better than adding a comment to it.
Normally, I would agree, but not in this case, where it's more likely correct to make the function used. rdar://problem/25471523 tracks that.