Bug 156071 - run-webkit-tests fails to create user's cache directory when System Integrity Protection is enabled
Summary: run-webkit-tests fails to create user's cache directory when System Integrity...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac OS X 10.11
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks: 155455
  Show dependency treegraph
 
Reported: 2016-03-31 10:48 PDT by Daniel Bates
Modified: 2016-03-31 16:45 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.38 KB, patch)
2016-03-31 15:29 PDT, Daniel Bates
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-03-31 10:48:14 PDT
On non-Apple Internal machines with System Integrity Protection enabled, run-webkit-tests fails to create the user's cache directory with suffix DIRHELPER_USER_DIR_SUFFIX because the path returned by os.confstr(65538) [1] does not include the suffix as confstr(3) only honors DIRHELPER_USER_DIR_SUFFIX for privileged processes when System Integrity Protection is enabled on non Apple-Internal machines.

[1] <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/mac.py?rev=198842#L126>
Comment 1 Radar WebKit Bug Importer 2016-03-31 10:48:48 PDT
<rdar://problem/25467827>
Comment 2 Daniel Bates 2016-03-31 15:29:02 PDT
Created attachment 275339 [details]
Patch
Comment 3 Brent Fulgham 2016-03-31 16:12:46 PDT
Comment on attachment 275339 [details]
Patch

r=me
Comment 4 Daniel Bates 2016-03-31 16:45:50 PDT
Committed r198930: <http://trac.webkit.org/changeset/198930>