Web Automation: Navigation commands should not return until page loads or fails

[Timothy Hatcher]

We need to block these endpoints on waiting until the page loads.

[Radar WebKit Bug Importer]

<rdar://problem/25464373>

[Timothy Hatcher]

Created attachment 275282 [details]
Patch

[BJ Burg]

Comment on attachment 275282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275282&action=review

> Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:418
> +}

I believe that this should cancel any pending async script evaluations first so that they error out. We can add this later.

> Source/WebKit2/UIProcess/Automation/WebAutomationSession.h:85
> +    void navigationOccuredForPage(const WebPageProxy&);

Please fix spelling: navigationOccurredForPage

> Source/WebKit2/UIProcess/WebPageProxy.cpp:3126
> +        if (auto automationSession = process().processPool().automationSession())

Nit: auto should be auto& or auto* so the type is less mysterious (and so we don't accidentally make a copy in some cases).

[Timothy Hatcher]

Comment on attachment 275282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275282&action=review

>> Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:418
>> +}
> 
> I believe that this should cancel any pending async script evaluations first so that they error out. We can add this later.

That is already done on the WebProcess side.

[Timothy Hatcher]

https://trac.webkit.org/r198914