Bug 156046 - Need to expose makeAllShadowRootsOpen in WKWebProcessPlugInScriptWorld.
Summary: Need to expose makeAllShadowRootsOpen in WKWebProcessPlugInScriptWorld.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-30 16:27 PDT by Yongjun Zhang
Modified: 2016-03-30 20:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch. (2.22 KB, patch)
2016-03-30 16:32 PDT, Yongjun Zhang 		mitz: review+
Details | Formatted Diff | Diff
Address review comment before landing. (2.26 KB, patch)
2016-03-30 19:57 PDT, Yongjun Zhang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2016-03-30 16:27:52 PDT 
http://trac.webkit.org/changeset/195686 added C SPI WKBundleScriptWorldMakeAllShadowRootsOpen, we should also expose makeAllShadowRootsOpen in WebKit ObjC SPI.
Comment 1 Yongjun Zhang 2016-03-30 16:32:33 PDT 
Created attachment 275235 [details]
Patch.
Comment 2 Yongjun Zhang 2016-03-30 16:33:37 PDT 
<rdar://problem/23183183>
Comment 3 mitz 2016-03-30 18:30:02 PDT 
Comment on attachment 275235 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=275235&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.h:41
> +- (void)makeAllShadowRootsOpen;

WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA)
Comment 4 Yongjun Zhang 2016-03-30 19:57:49 PDT 
Created attachment 275258 [details]
Address review comment before landing.
Comment 5 WebKit Commit Bot 2016-03-30 20:56:24 PDT 
Comment on attachment 275258 [details]
Address review comment before landing.

Clearing flags on attachment: 275258

Committed r198881: <http://trac.webkit.org/changeset/198881>
Comment 6 WebKit Commit Bot 2016-03-30 20:56:28 PDT 
All reviewed patches have been landed.  Closing bug.