Bug 156041 - Make BlobData use ThreadSafeSharedBuffer instead of RawData
Summary: Make BlobData use ThreadSafeSharedBuffer instead of RawData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 143193
  Show dependency tree / graph
 
Reported: 2016-03-30 14:46 PDT by Brady Eidson
Modified: 2016-03-30 22:45 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (37.22 KB, patch)
2016-03-30 16:59 PDT, Brady Eidson 		achristensen: review+
Details | Formatted Diff | Diff
Patch v2 - EWS and landing (39.72 KB, patch)
2016-03-30 17:23 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-03-30 14:46:00 PDT 
Make BlobData thread safe

This is in prep for https://bugs.webkit.org/show_bug.cgi?id=143193
Comment 1 Brady Eidson 2016-03-30 16:34:00 PDT 
Retitling:

Make BlobData use ThreadSafeSharedBuffer instead of RawData

That's all that is really needed here.

This, sadly, extends to touching various other code sites...
...but not so sad because it's a pretty nice cleanup! (removing dead code, etc)
Comment 2 Brady Eidson 2016-03-30 16:59:02 PDT 
Created attachment 275238 [details]
Patch v1
Comment 3 Brady Eidson 2016-03-30 17:23:38 PDT 
Created attachment 275242 [details]
Patch v2 - EWS and landing
Comment 4 WebKit Commit Bot 2016-03-30 18:21:03 PDT 
Comment on attachment 275242 [details]
Patch v2 - EWS and landing

Clearing flags on attachment: 275242

Committed r198869: <http://trac.webkit.org/changeset/198869>
Comment 5 WebKit Commit Bot 2016-03-30 18:21:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Carlos Alberto Lopez Perez 2016-03-30 20:04:11 PDT 
(In reply to comment #4)
> Comment on attachment 275242 [details]
> Patch v2 - EWS and landing
> 
> Clearing flags on attachment: 275242
> 
> Committed r198869: <http://trac.webkit.org/changeset/198869>

This broke the GTK+ debug build:

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/57122/steps/compile-webkit/logs/stdio/text
Comment 7 Brady Eidson 2016-03-30 20:59:52 PDT 
(In reply to comment #6)
> (In reply to comment #4)
> > Comment on attachment 275242 [details]
> > Patch v2 - EWS and landing
> > 
> > Clearing flags on attachment: 275242
> > 
> > Committed r198869: <http://trac.webkit.org/changeset/198869>
> 
> This broke the GTK+ debug build:
> 
> https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/
> builds/57122/steps/compile-webkit/logs/stdio/text

I fixed The build breakage from GTK EWS, which gave the final patch the green light.

That's about all that was in my power to do...
Comment 8 Brady Eidson 2016-03-30 21:19:35 PDT 
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #4)
> > > Comment on attachment 275242 [details]
> > > Patch v2 - EWS and landing
> > > 
> > > Clearing flags on attachment: 275242
> > > 
> > > Committed r198869: <http://trac.webkit.org/changeset/198869>
> > 
> > This broke the GTK+ debug build:
> > 
> > https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/
> > builds/57122/steps/compile-webkit/logs/stdio/text
> 
> I fixed The build breakage from GTK EWS, which gave the final patch the
> green light.
> 
> That's about all that was in my power to do...

Easy fixes...

ASSERT(blobItem.type == BlobDataItem::Type::File);
becomes
ASSERT(blobItem.type() == BlobDataItem::Type::File);

I'm at home without a clean checkout. If nobody has fixed that by tomorrow morning I'll check it in when I get into the office.
Comment 9 Alex Christensen 2016-03-30 22:45:14 PDT 
http://trac.webkit.org/changeset/198883