Bug 156041 – Make BlobData use ThreadSafeSharedBuffer instead of RawData

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Make BlobData thread safe

This is in prep for https://bugs.webkit.org/show_bug.cgi?id=143193

[Brady Eidson]

Retitling:

Make BlobData use ThreadSafeSharedBuffer instead of RawData

That's all that is really needed here.

This, sadly, extends to touching various other code sites...
...but not so sad because it's a pretty nice cleanup! (removing dead code, etc)

[Brady Eidson]

Created attachment 275238 [details]
Patch v1

[Brady Eidson]

Created attachment 275242 [details]
Patch v2 - EWS and landing

[WebKit Commit Bot]

Comment on attachment 275242 [details]
Patch v2 - EWS and landing

Clearing flags on attachment: 275242

Committed r198869: <http://trac.webkit.org/changeset/198869>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Carlos Alberto Lopez Perez]

(In reply to comment #4)
> Comment on attachment 275242 [details]
> Patch v2 - EWS and landing
> 
> Clearing flags on attachment: 275242
> 
> Committed r198869: <http://trac.webkit.org/changeset/198869>

This broke the GTK+ debug build:

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/57122/steps/compile-webkit/logs/stdio/text

[Brady Eidson]

(In reply to comment #6)
> (In reply to comment #4)
> > Comment on attachment 275242 [details]
> > Patch v2 - EWS and landing
> > 
> > Clearing flags on attachment: 275242
> > 
> > Committed r198869: <http://trac.webkit.org/changeset/198869>
> 
> This broke the GTK+ debug build:
> 
> https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/
> builds/57122/steps/compile-webkit/logs/stdio/text

I fixed The build breakage from GTK EWS, which gave the final patch the green light.

That's about all that was in my power to do...

[Brady Eidson]

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #4)
> > > Comment on attachment 275242 [details]
> > > Patch v2 - EWS and landing
> > > 
> > > Clearing flags on attachment: 275242
> > > 
> > > Committed r198869: <http://trac.webkit.org/changeset/198869>
> > 
> > This broke the GTK+ debug build:
> > 
> > https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/
> > builds/57122/steps/compile-webkit/logs/stdio/text
> 
> I fixed The build breakage from GTK EWS, which gave the final patch the
> green light.
> 
> That's about all that was in my power to do...

Easy fixes...

ASSERT(blobItem.type == BlobDataItem::Type::File);
becomes
ASSERT(blobItem.type() == BlobDataItem::Type::File);

I'm at home without a clean checkout. If nobody has fixed that by tomorrow morning I'll check it in when I get into the office.

[Alex Christensen]

http://trac.webkit.org/changeset/198883