Bug 156036 - Fix Content-Range requests when not using the NetworkCache with NetworkSession
Summary: Fix Content-Range requests when not using the NetworkCache with NetworkSession
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-30 13:01 PDT by Alex Christensen
Modified: 2016-04-05 18:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.88 KB, patch)
2016-03-30 13:14 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (2.97 KB, patch)
2016-04-04 11:39 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-03-30 13:01:13 PDT 
Fix Content-Range requests when not using the NetworkCache with NetworkSession
Comment 1 Alex Christensen 2016-03-30 13:14:05 PDT 
Created attachment 275215 [details]
Patch
Comment 2 Sam Weinig 2016-03-30 23:03:09 PDT 
Comment on attachment 275215 [details]
Patch

Test case?
Comment 3 Alex Christensen 2016-03-31 10:42:10 PDT 
I looked into writing an automated test case, but this is only needed when the NetworkCache is disabled, which is not true for WebKitTestRunner, and when loading from the network, which is not true for TestWebKitAPI.  Doing the manual test in the radar certainly shows that this fixes a problem with videos on WK2 apps with the NetworkCache disabled.
Comment 4 Darin Adler 2016-04-03 12:35:22 PDT 
Comment on attachment 275215 [details]
Patch

Could you please add a regression test?
Comment 5 Alex Christensen 2016-04-04 11:39:32 PDT 
Created attachment 275562 [details]
Patch
Comment 6 Alex Christensen 2016-04-04 11:53:16 PDT 
(In reply to comment #4)
> Comment on attachment 275215 [details]
> Patch
> 
> Could you please add a regression test?
I don't think it is reasonable to do this because this is to fix a compatibility bug with a program that does not use the NetworkCache, which is not possible with a program that is linked with a recent version of WebKit.
Comment 7 WebKit Commit Bot 2016-04-05 18:37:10 PDT 
Comment on attachment 275562 [details]
Patch

Clearing flags on attachment: 275562

Committed r199090: <http://trac.webkit.org/changeset/199090>
Comment 8 WebKit Commit Bot 2016-04-05 18:37:13 PDT 
All reviewed patches have been landed.  Closing bug.