Bug 156032 - Random SerializedScriptValue cleanup.
Summary: Random SerializedScriptValue cleanup.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-30 11:37 PDT by Brady Eidson
Modified: 2016-03-30 12:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch for EWS and landing (3.27 KB, patch)
2016-03-30 11:39 PDT, Brady Eidson 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-03-30 11:37:50 PDT 
Random SerializedScriptValue cleanup.
Comment 1 Brady Eidson 2016-03-30 11:39:04 PDT 
Created attachment 275205 [details]
Patch for EWS and landing
Comment 2 WebKit Commit Bot 2016-03-30 12:36:46 PDT 
Comment on attachment 275205 [details]
Patch for EWS and landing

Rejecting attachment 275205 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 275205, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Tim Hatcher found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/1071008
Comment 3 Brady Eidson 2016-03-30 12:42:26 PDT 
(In reply to comment #2)
> Comment on attachment 275205 [details]
> Patch for EWS and landing
> 
> Rejecting attachment 275205 [details] from commit-queue.
> 
> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch',
> '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03',
> 'validate-changelog', '--check-oops', '--non-interactive', 275205,
> '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
> 
> Tim Hatcher found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does
> not appear to be a valid reviewer according to contributors.json.
> /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid
> reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case
> insensitive).

omg.

"Rubber stamp" instead of "rubberstamped"

Sheesh.

Landing manually.
Comment 4 Brady Eidson 2016-03-30 12:43:22 PDT 
http://trac.webkit.org/changeset/198852