Bug 156027 - Avoid WebCore-prefixed paths when building WebCore
Summary: Avoid WebCore-prefixed paths when building WebCore
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Depends on:
Reported: 2016-03-30 10:23 PDT by Brent Fulgham
Modified: 2016-03-30 12:36 PDT (History)
5 users (show)

See Also:

Patch (7.95 KB, patch)
2016-03-30 10:27 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-03-30 10:23:33 PDT
A few files (e.g., “Font.h”, "ColorCG.h", some Video files) refer to “<WebCore/CoreGraphicsSPI.h>”, which doesn’t always exist on Windows at the time the file is compiled. The CoreGraphicsSPI.h file lives in “WebCore/platform/spi/cg/CoreGraphicsSPI.h”, and can be found with a normal ‘#include “CoreGraphicsSPI.h”. It’s only after a post-build step copies the file to “DerivedSources/ForwardingHeaders/WebCore/CoreGraphicsSPI.h” that the ‘#include <WebCore/CoreGraphicsSPI.h>” form works.

When a non-clean build is performed, this is fine, so EWS probably works properly most of the time. But if something prompts it to clean the build output, the file doesn’t exist and the build fails, improperly blaming the current patch.

We should be consistent about file access in WebCore so that we avoid these problems.
Comment 1 Brent Fulgham 2016-03-30 10:27:19 PDT
Created attachment 275197 [details]
Comment 2 David Kilzer (:ddkilzer) 2016-03-30 11:44:13 PDT
Comment on attachment 275197 [details]

Comment 3 WebKit Commit Bot 2016-03-30 12:36:10 PDT
Comment on attachment 275197 [details]

Clearing flags on attachment: 275197

Committed r198850: <http://trac.webkit.org/changeset/198850>
Comment 4 WebKit Commit Bot 2016-03-30 12:36:14 PDT
All reviewed patches have been landed.  Closing bug.