Bug 156016 - REGRESSION (r198808): 16 32-bit JSC tests fail after adding support for ES6 Symbol.isConcatSpreadable
Summary: REGRESSION (r198808): 16 32-bit JSC tests fail after adding support for ES6 S...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 156017 (view as bug list)
Depends on:
Blocks: 155351
  Show dependency tree / graph
 
Reported: 2016-03-30 01:57 PDT by David Kilzer (:ddkilzer)
Modified: 2016-04-04 01:56 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2016-03-30 01:57:13 PDT 
Between the Yosemite and El Capitan bots:

Yosemite:   <https://build.webkit.org/builders/Apple%20Yosemite%2032-bit%20JSC%20(BuildAndTest)?numbuilds=50>
El Capitan: <https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20(BuildAndTest)?numbuilds=50>

I found that r198808 (the fix for Bug 155351) caused 16 JSC tests to fail on 32-bit testers:

Build:  <https://build.webkit.org/builders/Apple%20Yosemite%2032-bit%20JSC%20%28BuildAndTest%29/builds/8602>

List of failing tests:

** The following JSC stress test failures have been introduced:
	jsc-layout-tests.yaml/js/script-tests/Object-assign.js.layout-dfg-eager-no-cjit
	jsc-layout-tests.yaml/js/script-tests/Object-assign.js.layout-ftl-eager-no-cjit
	stress/array-concat-spread-object.js.always-trigger-copy-phase
	stress/array-concat-spread-object.js.default
	stress/array-concat-spread-object.js.default-ftl
	stress/array-concat-spread-object.js.dfg-eager
	stress/array-concat-spread-object.js.dfg-eager-no-cjit-validate
	stress/array-concat-spread-object.js.dfg-maximal-flush-validate-no-cjit
	stress/array-concat-spread-object.js.ftl-eager
	stress/array-concat-spread-object.js.ftl-eager-no-cjit
	stress/array-concat-spread-object.js.ftl-no-cjit-no-inline-validate
	stress/array-concat-spread-object.js.ftl-no-cjit-no-put-stack-validate
	stress/array-concat-spread-object.js.ftl-no-cjit-small-pool
	stress/array-concat-spread-object.js.ftl-no-cjit-validate-sampling-profiler
	stress/array-concat-spread-object.js.no-cjit-validate-phases
	stress/array-concat-spread-object.js.no-llint

Results for JSC stress tests:
    16 failures found.
Comment 1 Csaba Osztrogonác 2016-03-30 02:55:30 PDT 
*** Bug 156017 has been marked as a duplicate of this bug. ***
Comment 2 Alexey Proskuryakov 2016-03-30 09:32:26 PDT 
Is there any reason to not just roll out the patch, as we normally do?
Comment 3 Csaba Osztrogonác 2016-03-30 10:25:25 PDT 
(In reply to comment #2)
> Is there any reason to not just roll out the patch, as we normally do?

No. Except that I don't roll out others patches even if they broke
the whole world. The author should watch the bots after landing
a patch and should rollout the buggy patch him/herself.
Comment 4 Csaba Osztrogonác 2016-04-04 01:56:06 PDT 
Close, because the original change was rolled out.