Bug 156006 - Make dependency injection in unit tests more explicit
Summary: Make dependency injection in unit tests more explicit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-29 20:30 PDT by Ryosuke Niwa
Modified: 2016-03-29 21:16 PDT (History)
7 users (show)

See Also:

Attachments
Cleanup (20.90 KB, patch)
2016-03-29 20:38 PDT, Ryosuke Niwa 		joepeck: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-03-29 20:30:59 PDT 
In order to run server tests and unit tests, we need to make
the dependency injection of mock models via before/beforeEach explicit
so that they won't collide with real model objects created in server tests.
Comment 1 Ryosuke Niwa 2016-03-29 20:38:49 PDT 
Created attachment 275171 [details]
Cleanup
Comment 2 Joseph Pecoraro 2016-03-29 21:13:57 PDT 
Comment on attachment 275171 [details]
Cleanup

r=me
Comment 3 Ryosuke Niwa 2016-03-29 21:16:44 PDT 
Committed r198826: <http://trac.webkit.org/changeset/198826>