RESOLVED FIXED 155996
Add a style for Data Detectors links 
https://bugs.webkit.org/show_bug.cgi?id=155996
Summary Add a style for Data Detectors links
Enrica Casucci
Reported 2016-03-29 16:49:42 PDT
Based on indication from the data detection engine, we should style some of the links differently. rdar://problem/25343514
Attachments
Patch (6.14 KB, patch)
2016-03-30 14:57 PDT, Enrica Casucci 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2016-03-30 14:57:42 PDT
Created attachment 275226 [details] Patch
Sam Weinig
Comment 2 2016-03-30 15:10:52 PDT
Comment on attachment 275226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275226&action=review > Source/WebCore/editing/cocoa/DataDetection.mm:55 > +const char *dataDetectorsLinkStyle = "-webkit-text-decoration-color:rgb(199, 199, 204); color:initial;"; * on the wrong side. > Source/WebCore/editing/cocoa/DataDetection.mm:332 > + isSubResult = length > 1; Is it really necessary for this calculation to happen in this function? Seems like it would be cleaner to do it at the call site.
Enrica Casucci
Comment 3 2016-03-30 15:14:56 PDT
> > Source/WebCore/editing/cocoa/DataDetection.mm:332 > > + isSubResult = length > 1; > > Is it really necessary for this calculation to happen in this function? > Seems like it would be cleaner to do it at the call site. I believe it makes more sense to do it inside the function where we decide what is a sub result.
Enrica Casucci
Comment 4 2016-03-30 15:16:48 PDT
(In reply to comment #3) > > > Source/WebCore/editing/cocoa/DataDetection.mm:332 > > > + isSubResult = length > 1; > > > > Is it really necessary for this calculation to happen in this function? > > Seems like it would be cleaner to do it at the call site. > I believe it makes more sense to do it inside the function where we decide > what is a sub result. Actually, I think you're correct. I'll change it.
Enrica Casucci
Comment 5 2016-03-30 16:09:56 PDT
Committed revision 198864.
Note You need to log in before you can comment on or make changes to this bug.