Bug 155982 - JSC::Debugger cleanup after recent changes
Summary: JSC::Debugger cleanup after recent changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-29 12:43 PDT by Joseph Pecoraro
Modified: 2016-03-29 13:12 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.77 KB, patch)
2016-03-29 12:45 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-03-29 12:43:55 PDT 
* SUMMARY
JSC::Debugger cleanup after recent changes.

1. Debugger should not start out assuming breakpoints are active.
2. Debugger does not need to recompile JS when enabling the Sampling Profiler! And I believe all ports are using the new sampling profiler!
Comment 1 Joseph Pecoraro 2016-03-29 12:45:52 PDT 
Created attachment 275120 [details]
[PATCH] Proposed Fix
Comment 2 Mark Lam 2016-03-29 12:50:56 PDT 
Comment on attachment 275120 [details]
[PATCH] Proposed Fix

r=me
Comment 3 Saam Barati 2016-03-29 12:51:33 PDT 
Comment on attachment 275120 [details]
[PATCH] Proposed Fix

LGTM too. Nice catch
Comment 4 WebKit Commit Bot 2016-03-29 13:12:17 PDT 
Comment on attachment 275120 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 275120

Committed r198791: <http://trac.webkit.org/changeset/198791>
Comment 5 WebKit Commit Bot 2016-03-29 13:12:20 PDT 
All reviewed patches have been landed.  Closing bug.