Bug 155981 - Web Inspector: REGRESSION: ⌘E and ⌘G text searching does not work
Summary: Web Inspector: REGRESSION: ⌘E and ⌘G text searching does not work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-29 11:38 PDT by Joseph Pecoraro
Modified: 2016-03-29 13:36 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (7.97 KB, patch)
2016-03-29 12:36 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-03-29 11:38:08 PDT 
* SUMMARY
⌘E and ⌘G text searching does not work.

* STEPS TO REPRODUCE
1. Inspect webkit.org
2. Show main resource
3. Double click "stylesheet"
4. Cmd-E to put into search buffer
5. Cmd-G to search forward
  => Nothing happens. Expected search forward!
Comment 1 Radar WebKit Bug Importer 2016-03-29 11:38:38 PDT 
<rdar://problem/25418983>
Comment 2 Joseph Pecoraro 2016-03-29 12:02:17 PDT 
This was partially caused by:
http://trac.webkit.org/changeset/198603

But mainly the problem is that the RecordingContentView in the background TimelineTab thinks it is visible and has activated its own keyboard shortcut handling:

    [Log] Trace: enableKeyboardShortcuts
    	enableKeyboardShortcuts (FindBanner.js:253)
    	shown (ContentBrowser.js:262)
    	shown (TimelineRecordingContentView.js:168)
    	prepareToShow (BackForwardEntry.js:78)
    	_showEntry (ContentViewContainer.js:485)
    	showBackForwardEntryForIndex (ContentViewContainer.js:150)
    	showContentView (ContentViewContainer.js:126)
    	_showTimelineViewForType (TimelineTabContentView.js:529)
    	restoreFromCookie (TimelineTabContentView.js:313)
    	_recordingSelected (TimelineTabContentView.js:478)
    	_recordingLoaded (TimelineTabContentView.js:483)
    	TimelineTabContentView (TimelineTabContentView.js:87)
    	_createTabContentViewForType (Main.js:490)
    	contentLoaded (Main.js:416)
    	(anonymous function)

Which gets first stab at the keyboard shortcut instead of the actually active tab's keyboard shortcut handling:

    [Log] Trace: enableKeyboardShortcuts
    	enableKeyboardShortcuts (FindBanner.js:253)
    	shown (ContentBrowser.js:262)
    	shown (ContentBrowserTabContentView.js:98)
    	prepareToShow (BackForwardEntry.js:78)
    	_showEntry (ContentViewContainer.js:485)
    	showBackForwardEntryForIndex (ContentViewContainer.js:150)
    	showContentView (ContentViewContainer.js:126)
    	_tabBarItemSelected (TabBrowser.js:204)
    	dispatch (Object.js:161)
    	dispatchEventToListeners (Object.js:168)
    	selectedTabBarItem (TabBar.js:374)
    	contentLoaded (Main.js:424)
    	(anonymous function)
Comment 3 Joseph Pecoraro 2016-03-29 12:36:44 PDT 
Created attachment 275119 [details]
[PATCH] Proposed Fix
Comment 4 WebKit Commit Bot 2016-03-29 13:36:35 PDT 
Comment on attachment 275119 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 275119

Committed r198794: <http://trac.webkit.org/changeset/198794>
Comment 5 WebKit Commit Bot 2016-03-29 13:36:38 PDT 
All reviewed patches have been landed.  Closing bug.