Bug 155981 – Web Inspector: REGRESSION: ⌘E and ⌘G text searching does not work

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
⌘E and ⌘G text searching does not work.

* STEPS TO REPRODUCE
1. Inspect webkit.org
2. Show main resource
3. Double click "stylesheet"
4. Cmd-E to put into search buffer
5. Cmd-G to search forward
  => Nothing happens. Expected search forward!

[Radar WebKit Bug Importer]

<rdar://problem/25418983>

[Joseph Pecoraro]

This was partially caused by:
http://trac.webkit.org/changeset/198603

But mainly the problem is that the RecordingContentView in the background TimelineTab thinks it is visible and has activated its own keyboard shortcut handling:

    [Log] Trace: enableKeyboardShortcuts
    	enableKeyboardShortcuts (FindBanner.js:253)
    	shown (ContentBrowser.js:262)
    	shown (TimelineRecordingContentView.js:168)
    	prepareToShow (BackForwardEntry.js:78)
    	_showEntry (ContentViewContainer.js:485)
    	showBackForwardEntryForIndex (ContentViewContainer.js:150)
    	showContentView (ContentViewContainer.js:126)
    	_showTimelineViewForType (TimelineTabContentView.js:529)
    	restoreFromCookie (TimelineTabContentView.js:313)
    	_recordingSelected (TimelineTabContentView.js:478)
    	_recordingLoaded (TimelineTabContentView.js:483)
    	TimelineTabContentView (TimelineTabContentView.js:87)
    	_createTabContentViewForType (Main.js:490)
    	contentLoaded (Main.js:416)
    	(anonymous function)

Which gets first stab at the keyboard shortcut instead of the actually active tab's keyboard shortcut handling:

    [Log] Trace: enableKeyboardShortcuts
    	enableKeyboardShortcuts (FindBanner.js:253)
    	shown (ContentBrowser.js:262)
    	shown (ContentBrowserTabContentView.js:98)
    	prepareToShow (BackForwardEntry.js:78)
    	_showEntry (ContentViewContainer.js:485)
    	showBackForwardEntryForIndex (ContentViewContainer.js:150)
    	showContentView (ContentViewContainer.js:126)
    	_tabBarItemSelected (TabBrowser.js:204)
    	dispatch (Object.js:161)
    	dispatchEventToListeners (Object.js:168)
    	selectedTabBarItem (TabBar.js:374)
    	contentLoaded (Main.js:424)
    	(anonymous function)

[Joseph Pecoraro]

Created attachment 275119 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 275119 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 275119

Committed r198794: <http://trac.webkit.org/changeset/198794>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.