Bug 155980 - Move the CG ImageDecoder class from ImageSourceCG.cpp to ImageDecoderCG.h and .cpp
Summary: Move the CG ImageDecoder class from ImageSourceCG.cpp to ImageDecoderCG.h and...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-29 11:29 PDT by Said Abou-Hallawa
Modified: 2016-03-30 12:10 PDT (History)
2 users (show)

See Also:


Attachments
Patch (47.95 KB, patch)
2016-03-29 11:32 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (47.60 KB, patch)
2016-03-29 16:02 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (47.53 KB, patch)
2016-03-29 16:55 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (47.68 KB, patch)
2016-03-30 10:39 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2016-03-29 11:29:28 PDT
This is a clean up step after r198782.
Comment 1 Said Abou-Hallawa 2016-03-29 11:32:20 PDT
Created attachment 275113 [details]
Patch
Comment 2 Said Abou-Hallawa 2016-03-29 16:02:39 PDT
Created attachment 275143 [details]
Patch
Comment 3 Said Abou-Hallawa 2016-03-29 16:55:16 PDT
Created attachment 275152 [details]
Patch
Comment 4 Simon Fraser (smfr) 2016-03-29 18:07:34 PDT
Comment on attachment 275152 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275152&action=review

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.h:55
> +    IntSize frameSizeAtIndex(size_t, SubsamplingLevel) const;

Original or subsampled size? Maybe we should have typedefs for those.
Comment 5 Said Abou-Hallawa 2016-03-30 10:39:53 PDT
Created attachment 275200 [details]
Patch
Comment 6 WebKit Commit Bot 2016-03-30 12:10:16 PDT
Comment on attachment 275200 [details]
Patch

Clearing flags on attachment: 275200

Committed r198849: <http://trac.webkit.org/changeset/198849>
Comment 7 WebKit Commit Bot 2016-03-30 12:10:19 PDT
All reviewed patches have been landed.  Closing bug.