Bug 155964 - Shield WebRTC JS built-ins from user scripts
Summary: Shield WebRTC JS built-ins from user scripts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-29 00:36 PDT by youenn fablet
Modified: 2016-07-04 11:32 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.13 KB, patch)
2016-06-29 06:08 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Improving test (7.18 KB, patch)
2016-07-04 06:55 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-03-29 00:36:30 PDT
We should shield WebRTC JS built-ins from user scripts, for instance in RTCPeerConnection.js or RTCPeerConnectionInternals.
Comment 1 youenn fablet 2016-06-29 06:08:49 PDT
Created attachment 282342 [details]
Patch
Comment 2 youenn fablet 2016-07-04 06:55:22 PDT
Created attachment 282715 [details]
Improving test
Comment 3 youenn fablet 2016-07-04 06:59:10 PDT
(In reply to comment #2)
> Created attachment 282715 [details]
> Improving test

I run the tests and the patch worked as expected on the modified tests (removing console.log lines).

To be noted though that the two modified tests need rebasing (before and after this patch) and are skipped by default.
Is there a reason to skip them?
Should they be activated for GTK?
It seems that they are useful even if not fully passing yet.
Comment 4 WebKit Commit Bot 2016-07-04 11:32:09 PDT
Comment on attachment 282715 [details]
Improving test

Clearing flags on attachment: 282715

Committed r202810: <http://trac.webkit.org/changeset/202810>
Comment 5 WebKit Commit Bot 2016-07-04 11:32:13 PDT
All reviewed patches have been landed.  Closing bug.