WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
155964
Shield WebRTC JS built-ins from user scripts
https://bugs.webkit.org/show_bug.cgi?id=155964
Summary
Shield WebRTC JS built-ins from user scripts
youenn fablet
Reported
2016-03-29 00:36:30 PDT
We should shield WebRTC JS built-ins from user scripts, for instance in RTCPeerConnection.js or RTCPeerConnectionInternals.
Attachments
Patch
(7.13 KB, patch)
2016-06-29 06:08 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Improving test
(7.18 KB, patch)
2016-07-04 06:55 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2016-06-29 06:08:49 PDT
Created
attachment 282342
[details]
Patch
youenn fablet
Comment 2
2016-07-04 06:55:22 PDT
Created
attachment 282715
[details]
Improving test
youenn fablet
Comment 3
2016-07-04 06:59:10 PDT
(In reply to
comment #2
)
> Created
attachment 282715
[details]
> Improving test
I run the tests and the patch worked as expected on the modified tests (removing console.log lines). To be noted though that the two modified tests need rebasing (before and after this patch) and are skipped by default. Is there a reason to skip them? Should they be activated for GTK? It seems that they are useful even if not fully passing yet.
WebKit Commit Bot
Comment 4
2016-07-04 11:32:09 PDT
Comment on
attachment 282715
[details]
Improving test Clearing flags on attachment: 282715 Committed
r202810
: <
http://trac.webkit.org/changeset/202810
>
WebKit Commit Bot
Comment 5
2016-07-04 11:32:13 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug