Bug 155963 - Web Automation: Add SPI to tell whether an NSEvent was synthesized for automation
Summary: Web Automation: Add SPI to tell whether an NSEvent was synthesized for automa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-28 21:12 PDT by BJ Burg
Modified: 2016-03-29 13:21 PDT (History)
7 users (show)

See Also:


Attachments
Proposed Fix (5.45 KB, patch)
2016-03-29 09:24 PDT, BJ Burg
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-03-28 21:12:02 PDT
It was Joe's Idea.
Comment 1 Radar WebKit Bug Importer 2016-03-28 21:12:54 PDT
<rdar://problem/25405747>
Comment 2 BJ Burg 2016-03-29 09:24:50 PDT
Created attachment 275099 [details]
Proposed Fix
Comment 3 Timothy Hatcher 2016-03-29 09:47:38 PDT
Comment on attachment 275099 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=275099&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKAutomationSession.h:43
> +- (BOOL)eventWasSynthesizedForAutomation:(NSEvent *)event;

I think this needs to be: wasEventSynthesizedForAutomation:

> Source/WebKit2/UIProcess/Automation/WebAutomationSession.h:117
> +    bool eventWasSynthesizedForAutomation(NSEvent *);

Ditto.
Comment 4 BJ Burg 2016-03-29 13:21:43 PDT
Committed: <http://trac.webkit.org/changeset/198793>