Bug 155951 – Modern IDB: Remove abstract base classes for all IDB DOM classes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Modern IDB: Remove abstract base classes for all IDB DOM classes

Not needed anymore since we've removed Legacy IDB.

[Brady Eidson]

Created attachment 275039 [details]
Patch v1

[WebKit Commit Bot]

Attachment 275039 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBCursor.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBRequest.cpp:288:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 3 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 275039 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=275039&action=review

> Source/WebCore/Modules/indexeddb/IDBAny.cpp:48
> +    , m_database(adoptRef(&database.leakRef()))

WTFMove

> Source/WebCore/Modules/indexeddb/IDBFactory.h:-53
> -    // FIXME: getDatabaseNames is no longer a web-facing API, and should be removed from IDBFactory.
> -    // The Web Inspector currently uses this to enumerate the list of databases, but is more complicated as a result.
> -    // We should provide a simpler API to the Web Inspector then remove getDatabaseNames.

Is this still true?

[Brady Eidson]

(In reply to comment #3)
> Comment on attachment 275039 [details]
> > Source/WebCore/Modules/indexeddb/IDBFactory.h:-53
> > -    // FIXME: getDatabaseNames is no longer a web-facing API, and should be removed from IDBFactory.
> > -    // The Web Inspector currently uses this to enumerate the list of databases, but is more complicated as a result.
> > -    // We should provide a simpler API to the Web Inspector then remove getDatabaseNames.
> 
> Is this still true?

Yes.

[Alex Christensen]

Comment on attachment 275039 [details]
Patch v1

Then we should keep the comment.

[Brady Eidson]

Created attachment 275051 [details]
Patch for landing v1

[Brady Eidson]

Created attachment 275052 [details]
Patch for landing v2

[WebKit Commit Bot]

Comment on attachment 275052 [details]
Patch for landing v2

Clearing flags on attachment: 275052

Committed r198762: <http://trac.webkit.org/changeset/198762>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.