Bug 155951 - Modern IDB: Remove abstract base classes for all IDB DOM classes
Summary: Modern IDB: Remove abstract base classes for all IDB DOM classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117
  Show dependency tree / graph
 
Reported: 2016-03-28 12:46 PDT by Brady Eidson
Modified: 2016-03-28 15:49 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (437.83 KB, patch)
2016-03-28 13:01 PDT, Brady Eidson 		achristensen: review+
Details | Formatted Diff | Diff
Patch for landing v1 (437.80 KB, patch)
2016-03-28 14:21 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch for landing v2 (438.84 KB, patch)
2016-03-28 14:23 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-03-28 12:46:50 PDT 
Modern IDB: Remove abstract base classes for all IDB DOM classes

Not needed anymore since we've removed Legacy IDB.
Comment 1 Brady Eidson 2016-03-28 13:01:39 PDT 
Created attachment 275039 [details]
Patch v1
Comment 2 WebKit Commit Bot 2016-03-28 13:03:20 PDT 
Attachment 275039 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBCursor.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBRequest.cpp:288:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 3 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2016-03-28 13:15:23 PDT 
Comment on attachment 275039 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=275039&action=review

> Source/WebCore/Modules/indexeddb/IDBAny.cpp:48
> +    , m_database(adoptRef(&database.leakRef()))

WTFMove

> Source/WebCore/Modules/indexeddb/IDBFactory.h:-53
> -    // FIXME: getDatabaseNames is no longer a web-facing API, and should be removed from IDBFactory.
> -    // The Web Inspector currently uses this to enumerate the list of databases, but is more complicated as a result.
> -    // We should provide a simpler API to the Web Inspector then remove getDatabaseNames.

Is this still true?
Comment 4 Brady Eidson 2016-03-28 13:25:09 PDT 
(In reply to comment #3)
> Comment on attachment 275039 [details]
> > Source/WebCore/Modules/indexeddb/IDBFactory.h:-53
> > -    // FIXME: getDatabaseNames is no longer a web-facing API, and should be removed from IDBFactory.
> > -    // The Web Inspector currently uses this to enumerate the list of databases, but is more complicated as a result.
> > -    // We should provide a simpler API to the Web Inspector then remove getDatabaseNames.
> 
> Is this still true?

Yes.
Comment 5 Alex Christensen 2016-03-28 13:56:55 PDT 
Comment on attachment 275039 [details]
Patch v1

Then we should keep the comment.
Comment 6 Brady Eidson 2016-03-28 14:21:11 PDT 
Created attachment 275051 [details]
Patch for landing v1
Comment 7 Brady Eidson 2016-03-28 14:23:20 PDT 
Created attachment 275052 [details]
Patch for landing v2
Comment 8 WebKit Commit Bot 2016-03-28 15:49:05 PDT 
Comment on attachment 275052 [details]
Patch for landing v2

Clearing flags on attachment: 275052

Committed r198762: <http://trac.webkit.org/changeset/198762>
Comment 9 WebKit Commit Bot 2016-03-28 15:49:10 PDT 
All reviewed patches have been landed.  Closing bug.