Bug 155920 - Misc. JavaScriptCore built-ins cleanups
Summary: Misc. JavaScriptCore built-ins cleanups
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-25 22:26 PDT by Joseph Pecoraro
Modified: 2016-03-25 23:51 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.94 KB, patch)
2016-03-25 22:27 PDT, Joseph Pecoraro 		sam: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff
[PATCH] Proposed Fix (4.98 KB, patch)
2016-03-25 22:50 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-03-25 22:26:39 PDT 
* SUMMARY
Misc. JavaScriptCore built-ins cleanups.

Some weird styles and a typo in an error message.
Comment 1 Joseph Pecoraro 2016-03-25 22:27:57 PDT 
Created attachment 274975 [details]
[PATCH] Proposed Fix
Comment 2 Sam Weinig 2016-03-25 22:30:32 PDT 
Comment on attachment 274975 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=274975&action=review

> Source/JavaScriptCore/builtins/TypedArrayConstructor.js:37
> +        throw new @TypeError("TypedArray.of requires its this argument to subclass a TypedArray constructor");

Can we test this?
Comment 3 Joseph Pecoraro 2016-03-25 22:50:25 PDT 
Created attachment 274978 [details]
[PATCH] Proposed Fix

Now with a test.
Comment 4 Mark Lam 2016-03-25 22:53:15 PDT 
Comment on attachment 274978 [details]
[PATCH] Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2016-03-25 23:51:13 PDT 
Comment on attachment 274978 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 274978

Committed r198713: <http://trac.webkit.org/changeset/198713>
Comment 6 WebKit Commit Bot 2016-03-25 23:51:16 PDT 
All reviewed patches have been landed.  Closing bug.