Bug 155903 - [JSC] fix divide-by-zero in String.prototype.padStart/padEnd
Summary: [JSC] fix divide-by-zero in String.prototype.padStart/padEnd
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-25 14:48 PDT by Caitlin Potter (:caitp)
Modified: 2016-03-25 16:04 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.65 KB, patch)
2016-03-25 14:49 PDT, Caitlin Potter (:caitp) 		no flags Details | Formatted Diff | Diff
Patch (1.56 KB, patch)
2016-03-25 15:05 PDT, Caitlin Potter (:caitp) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caitlin Potter (:caitp) 2016-03-25 14:48:34 PDT 
[JSC] fix divide-by-zero in String.prototype.padStart/padEnd
Comment 1 Caitlin Potter (:caitp) 2016-03-25 14:49:15 PDT 
Created attachment 274941 [details]
Patch
Comment 2 Filip Pizlo 2016-03-25 14:50:54 PDT 
Comment on attachment 274941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274941&action=review

> Source/JavaScriptCore/tests/es6.yaml:-580
> -- path: es6/String.prototype_methods_String.prototype.padEnd.js
> -  cmd: runES6 :normal
> -- path: es6/String.prototype_methods_String.prototype.padStart.js
> -  cmd: runES6 :normal

Why is this moved?
Comment 3 Caitlin Potter (:caitp) 2016-03-25 14:52:43 PDT 
Comment on attachment 274941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274941&action=review

>> Source/JavaScriptCore/tests/es6.yaml:-580
>> -  cmd: runES6 :normal
> 
> Why is this moved?

Wanted to move this down to be near TODO regarding tests for future ES spec revisions
Comment 4 Filip Pizlo 2016-03-25 15:02:51 PDT 
(In reply to comment #3)
> Comment on attachment 274941 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274941&action=review
> 
> >> Source/JavaScriptCore/tests/es6.yaml:-580
> >> -  cmd: runES6 :normal
> > 
> > Why is this moved?
> 
> Wanted to move this down to be near TODO regarding tests for future ES spec
> revisions

Can you move this back?

This is meant to be a quick fix to make tests pass, so we shouldn't be making unrelated changes in this same patch.
Comment 5 Caitlin Potter (:caitp) 2016-03-25 15:05:18 PDT 
Created attachment 274944 [details]
Patch
Comment 6 WebKit Commit Bot 2016-03-25 16:04:03 PDT 
Comment on attachment 274944 [details]
Patch

Clearing flags on attachment: 274944

Committed r198695: <http://trac.webkit.org/changeset/198695>
Comment 7 WebKit Commit Bot 2016-03-25 16:04:08 PDT 
All reviewed patches have been landed.  Closing bug.