Bug 155891 - [Mac] Audio tracks in alternate groups are not represented correctly as AudioTracks
Summary: [Mac] Audio tracks in alternate groups are not represented correctly as Audio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-25 10:28 PDT by Jer Noble
Modified: 2016-10-31 09:18 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.57 MB, patch)
2016-03-25 10:53 PDT, Jer Noble
eric.carlson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-yosemite (769.02 KB, application/zip)
2016-03-25 11:41 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (914.71 KB, application/zip)
2016-03-25 11:43 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews117 for mac-yosemite (837.03 KB, application/zip)
2016-03-25 11:55 PDT, Build Bot
no flags Details
Patch for landing (4.57 MB, patch)
2016-03-25 12:54 PDT, Jer Noble
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (771.39 KB, application/zip)
2016-03-25 13:41 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (771.42 KB, application/zip)
2016-03-25 13:44 PDT, Build Bot
no flags Details
Patch for landing (4.57 MB, patch)
2016-03-25 13:52 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-yosemite (886.61 KB, application/zip)
2016-03-25 14:05 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-03-25 10:28:33 PDT
[Mac] Audio tracks in alternate groups are not represented correctly as AudioTracks
Comment 1 Jer Noble 2016-03-25 10:53:58 PDT
Created attachment 274918 [details]
Patch
Comment 2 Jer Noble 2016-03-25 10:55:53 PDT
<rdar://problem/24841372>
Comment 3 Build Bot 2016-03-25 11:41:43 PDT
Comment on attachment 274918 [details]
Patch

Attachment 274918 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1038169

New failing tests:
media/track/video-track-alternate-groups.html
Comment 4 Build Bot 2016-03-25 11:41:45 PDT
Created attachment 274922 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-03-25 11:43:08 PDT
Created attachment 274923 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-03-25 11:55:51 PDT
Comment on attachment 274918 [details]
Patch

Attachment 274918 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1038181

New failing tests:
media/track/video-track-alternate-groups.html
Comment 7 Build Bot 2016-03-25 11:55:54 PDT
Created attachment 274924 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Jer Noble 2016-03-25 12:54:28 PDT
Created attachment 274928 [details]
Patch for landing
Comment 9 Build Bot 2016-03-25 13:41:22 PDT
Comment on attachment 274928 [details]
Patch for landing

Attachment 274928 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1038588

New failing tests:
media/track/video-track-alternate-groups.html
Comment 10 Build Bot 2016-03-25 13:41:25 PDT
Created attachment 274935 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Build Bot 2016-03-25 13:44:49 PDT
Comment on attachment 274928 [details]
Patch for landing

Attachment 274928 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1038593

New failing tests:
media/track/video-track-alternate-groups.html
Comment 12 Build Bot 2016-03-25 13:44:52 PDT
Created attachment 274937 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 13 Jer Noble 2016-03-25 13:52:28 PDT
Created attachment 274938 [details]
Patch for landing
Comment 14 Build Bot 2016-03-25 14:05:07 PDT
Comment on attachment 274928 [details]
Patch for landing

Attachment 274928 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1038632

New failing tests:
media/track/video-track-alternate-groups.html
Comment 15 Build Bot 2016-03-25 14:05:10 PDT
Created attachment 274939 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 16 WebKit Commit Bot 2016-03-25 17:26:47 PDT
Comment on attachment 274938 [details]
Patch for landing

Clearing flags on attachment: 274938

Committed r198703: <http://trac.webkit.org/changeset/198703>
Comment 17 Ryan Haddad 2016-03-25 18:23:54 PDT
The test added with this change appears to be failing on El Capitan:

--- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/media/track/video-track-alternate-groups-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/media/track/video-track-alternate-groups-actual.txt
@@ -21,8 +21,8 @@
 RUN(video.src = findMediaFile("video", "../content/audio-tracks-alternate-group-with-fallback"))
 EVENT(canplaythrough)
 EXPECTED (video.audioTracks.length == '3') OK
-TRACK id:2 kind:main language:en
-TRACK id:4 kind:main language:fr
-TRACK id:6 kind:main language:es
+TRACK id:3 kind:main language:en
+TRACK id:5 kind:main language:fr
+TRACK id:7 kind:main language:es
 END OF TEST
 
https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r198703%20(4613)/results.html
https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r198704%20(4739)/results.html

Is this a sign of a problem, or do we just need a rebaseline for El Capitan?
Comment 18 Jer Noble 2016-03-28 08:44:28 PDT
(In reply to comment #17)
> The test added with this change appears to be failing on El Capitan:
> 
> ---
> /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/
> media/track/video-track-alternate-groups-expected.txt
> +++
> /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/
> media/track/video-track-alternate-groups-actual.txt
> @@ -21,8 +21,8 @@
>  RUN(video.src = findMediaFile("video",
> "../content/audio-tracks-alternate-group-with-fallback"))
>  EVENT(canplaythrough)
>  EXPECTED (video.audioTracks.length == '3') OK
> -TRACK id:2 kind:main language:en
> -TRACK id:4 kind:main language:fr
> -TRACK id:6 kind:main language:es
> +TRACK id:3 kind:main language:en
> +TRACK id:5 kind:main language:fr
> +TRACK id:7 kind:main language:es
>  END OF TEST
>  
> https://build.webkit.org/results/
> Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r198703%20(4613)/results.html
> https://build.webkit.org/results/
> Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r198704%20(4739)/results.html
> 
> Is this a sign of a problem, or do we just need a rebaseline for El Capitan?

That implies that this machine is choosing the AC-3 tracks. Yes, let's rebaseline.
Comment 19 Jer Noble 2016-03-28 09:15:45 PDT
(In reply to comment #18)
> (In reply to comment #17)
> > The test added with this change appears to be failing on El Capitan:
> > 
> > ---
> > /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/
> > media/track/video-track-alternate-groups-expected.txt
> > +++
> > /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/
> > media/track/video-track-alternate-groups-actual.txt
> > @@ -21,8 +21,8 @@
> >  RUN(video.src = findMediaFile("video",
> > "../content/audio-tracks-alternate-group-with-fallback"))
> >  EVENT(canplaythrough)
> >  EXPECTED (video.audioTracks.length == '3') OK
> > -TRACK id:2 kind:main language:en
> > -TRACK id:4 kind:main language:fr
> > -TRACK id:6 kind:main language:es
> > +TRACK id:3 kind:main language:en
> > +TRACK id:5 kind:main language:fr
> > +TRACK id:7 kind:main language:es
> >  END OF TEST
> >  
> > https://build.webkit.org/results/
> > Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r198703%20(4613)/results.html
> > https://build.webkit.org/results/
> > Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r198704%20(4739)/results.html
> > 
> > Is this a sign of a problem, or do we just need a rebaseline for El Capitan?
> 
> That implies that this machine is choosing the AC-3 tracks. Yes, let's
> rebaseline.

Rebaselined in r198742.