Bug 155890 - Disk cache speculative validation requests do not have the 'Referer' HTTP header set
Summary: Disk cache speculative validation requests do not have the 'Referer' HTTP hea...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-25 10:23 PDT by Chris Dumez
Modified: 2016-03-28 09:04 PDT (History)
7 users (show)

See Also:

Attachments
Patch (29.85 KB, patch)
2016-03-27 15:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (31.00 KB, patch)
2016-03-28 09:03 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-03-25 10:23:25 PDT 
Disk cache speculative validation requests do not have the 'Referer' HTTP header set. This is breaking some streaming sites (such as twitch.tv).
Comment 1 Chris Dumez 2016-03-25 10:23:46 PDT 
rdar://problem/25279962
Comment 2 Chris Dumez 2016-03-27 15:39:32 PDT 
Created attachment 274999 [details]
Patch
Comment 3 Antti Koivisto 2016-03-28 05:34:50 PDT 
Comment on attachment 274999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274999&action=review

r=me

> LayoutTests/http/tests/cache/disk-cache/speculative-validation/validation-request-expected.txt:8
> +PASS validationRequestHeader('Referer') is initialReferer

The test seems rather barebones considering this affects all headers, not just "Referer'
Comment 4 Chris Dumez 2016-03-28 09:03:47 PDT 
Created attachment 275022 [details]
Patch
Comment 5 Chris Dumez 2016-03-28 09:04:31 PDT 
Comment on attachment 275022 [details]
Patch

Clearing flags on attachment: 275022

Committed r198741: <http://trac.webkit.org/changeset/198741>
Comment 6 Chris Dumez 2016-03-28 09:04:36 PDT 
All reviewed patches have been landed.  Closing bug.