Bug 155889 - WebKit.xcworkspace "All Source" scheme always copies OS X WebKitSystemInterface libraries
Summary: WebKit.xcworkspace "All Source" scheme always copies OS X WebKitSystemInterfa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 9.3
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-25 10:19 PDT by Daniel Bates
Modified: 2016-03-27 22:07 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.04 KB, patch)
2016-03-25 10:21 PDT, Daniel Bates
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-03-25 10:19:04 PDT
The WebKit.xcworkspace "All Source" scheme always copies the OS X WebKitSystemInterface libraries regardless of the selected base SDK. We should copy the SDK-specific WebKitSystemInterface libraries.
Comment 1 Daniel Bates 2016-03-25 10:21:25 PDT
Created attachment 274915 [details]
Patch
Comment 2 Alexey Proskuryakov 2016-03-25 10:56:05 PDT
Comment on attachment 274915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274915&action=review

> WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:12
> +               scriptText = ""$SRCROOT/../../Tools/Scripts/copy-webkitlibraries-to-product-directory" --wksi --sdk $SDKROOT">

How does this work? I thought that --sdk took names like "iphonesimulator", not paths.
Comment 3 Daniel Bates 2016-03-25 11:40:06 PDT
(In reply to comment #2)
> > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:12
> > +               scriptText = ""$SRCROOT/../../Tools/Scripts/copy-webkitlibraries-to-product-directory" --wksi --sdk $SDKROOT">
> 
> How does this work? I thought that --sdk took names like "iphonesimulator",
> not paths.

--sdk can take a path, just like the command line option of the same name for xcrun. The code in webkitdirs.pm knows how to reason about an SDK given as a path.
Comment 4 Daniel Bates 2016-03-25 11:48:14 PDT
> > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:12
> > +               scriptText = ""$SRCROOT/../../Tools/Scripts/copy-webkitlibraries-to-product-directory" --wksi --sdk $SDKROOT">
> 

Will add "s around $SDKROOT before landing as it may contain space characters.
Comment 5 Daniel Bates 2016-03-27 22:07:08 PDT
Committed r198727: <http://trac.webkit.org/changeset/198727>