Bug 155889 – WebKit.xcworkspace "All Source" scheme always copies OS X WebKitSystemInterface libraries

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

The WebKit.xcworkspace "All Source" scheme always copies the OS X WebKitSystemInterface libraries regardless of the selected base SDK. We should copy the SDK-specific WebKitSystemInterface libraries.

[Daniel Bates]

Created attachment 274915 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 274915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274915&action=review

> WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:12
> +               scriptText = ""$SRCROOT/../../Tools/Scripts/copy-webkitlibraries-to-product-directory" --wksi --sdk $SDKROOT">

How does this work? I thought that --sdk took names like "iphonesimulator", not paths.

[Daniel Bates]

(In reply to comment #2)
> > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:12
> > +               scriptText = ""$SRCROOT/../../Tools/Scripts/copy-webkitlibraries-to-product-directory" --wksi --sdk $SDKROOT">
> 
> How does this work? I thought that --sdk took names like "iphonesimulator",
> not paths.

--sdk can take a path, just like the command line option of the same name for xcrun. The code in webkitdirs.pm knows how to reason about an SDK given as a path.

[Daniel Bates]

> > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:12
> > +               scriptText = ""$SRCROOT/../../Tools/Scripts/copy-webkitlibraries-to-product-directory" --wksi --sdk $SDKROOT">
> 

Will add "s around $SDKROOT before landing as it may contain space characters.

[Daniel Bates]

Committed r198727: <http://trac.webkit.org/changeset/198727>