Bug 155888 - Web Automation: Add Automation protocol commands to handle JavaScript dialogs
Summary: Web Automation: Add Automation protocol commands to handle JavaScript dialogs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-25 09:58 PDT by Timothy Hatcher
Modified: 2016-03-28 09:41 PDT (History)
7 users (show)

See Also:


Attachments
Patch (18.50 KB, patch)
2016-03-25 10:00 PDT, Timothy Hatcher
bburg: review+
timothy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-03-25 09:58:02 PDT
We need to accept, dismiss and get the message. Prompts need support for setting the user input.
Comment 1 Radar WebKit Bug Importer 2016-03-25 09:58:31 PDT
<rdar://problem/25360218>
Comment 2 Timothy Hatcher 2016-03-25 10:00:22 PDT
Created attachment 274912 [details]
Patch
Comment 3 BJ Burg 2016-03-25 17:20:06 PDT
Comment on attachment 274912 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274912&action=review

r=me

> Source/WebKit2/UIProcess/Automation/Automation.json:299
> +            "name": "setUserInputForCurrentJavaScriptPrompt",

Can this be renamed to 'insertTextForCurrentJavaScriptPrompt' ? The setXXX prefix doesn't translate well to ObjC.
Comment 4 Timothy Hatcher 2016-03-28 09:41:48 PDT
https://trac.webkit.org/r198740