Bug 155882 – Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Konstantin Tokarev]

It was already enabled in all trunk ports, and is required for WebInspectorUI to work.

[Konstantin Tokarev]

Created attachment 274901 [details]
Patch

[Csaba Osztrogonác]

You could remove it from OptionsWin.cmake too.

[Konstantin Tokarev]

(In reply to comment #2)
> You could remove it from OptionsWin.cmake too.

And from OptionsEfl, as well. I haven't done that because Win and Efl declare this option as PUBLIC, so it would change behavior, but if everyone agrees I'll remove these too.

[Csaba Osztrogonác]

After a little digging, I found a 2 years old webkit-dev discussion:
https://lists.webkit.org/pipermail/webkit-dev/2014-March/026366.html

In this case it would be better to completely remove
ENABLE(REQUEST_ANIMATION_FRAME) guards from the trunk.

[Konstantin Tokarev]

Note that WebKit currently builds fine for me with !ENABLE(REQUEST_ANIMATION_FRAME), so apparently it requires almost no effort to maintain.

[Michael Catanzaro]

(In reply to comment #4)
> In this case it would be better to completely remove
> ENABLE(REQUEST_ANIMATION_FRAME) guards from the trunk.

I agree, we want to remove build options whenever they're not needed anymore, and this seems like a clear candidate.

[WebKit Commit Bot]

Comment on attachment 274901 [details]
Patch

Clearing flags on attachment: 274901

Committed r198666: <http://trac.webkit.org/changeset/198666>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.