Bug 155882 - Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.
Summary: Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-25 05:26 PDT by Konstantin Tokarev
Modified: 2016-03-25 07:47 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.14 KB, patch)
2016-03-25 05:30 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-03-25 05:26:09 PDT 
It was already enabled in all trunk ports, and is required for WebInspectorUI to work.
Comment 1 Konstantin Tokarev 2016-03-25 05:30:18 PDT 
Created attachment 274901 [details]
Patch
Comment 2 Csaba Osztrogonác 2016-03-25 06:30:54 PDT 
You could remove it from OptionsWin.cmake too.
Comment 3 Konstantin Tokarev 2016-03-25 06:32:31 PDT 
(In reply to comment #2)
> You could remove it from OptionsWin.cmake too.

And from OptionsEfl, as well. I haven't done that because Win and Efl declare this option as PUBLIC, so it would change behavior, but if everyone agrees I'll remove these too.
Comment 4 Csaba Osztrogonác 2016-03-25 06:35:59 PDT 
After a little digging, I found a 2 years old webkit-dev discussion:
https://lists.webkit.org/pipermail/webkit-dev/2014-March/026366.html

In this case it would be better to completely remove
ENABLE(REQUEST_ANIMATION_FRAME) guards from the trunk.
Comment 5 Konstantin Tokarev 2016-03-25 06:41:09 PDT 
Note that WebKit currently builds fine for me with !ENABLE(REQUEST_ANIMATION_FRAME), so apparently it requires almost no effort to maintain.
Comment 6 Michael Catanzaro 2016-03-25 06:58:15 PDT 
(In reply to comment #4)
> In this case it would be better to completely remove
> ENABLE(REQUEST_ANIMATION_FRAME) guards from the trunk.

I agree, we want to remove build options whenever they're not needed anymore, and this seems like a clear candidate.
Comment 7 WebKit Commit Bot 2016-03-25 07:47:49 PDT 
Comment on attachment 274901 [details]
Patch

Clearing flags on attachment: 274901

Committed r198666: <http://trac.webkit.org/changeset/198666>
Comment 8 WebKit Commit Bot 2016-03-25 07:47:55 PDT 
All reviewed patches have been landed.  Closing bug.