Bug 155869 - Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK() in copy-webkitlibraries-to-product-directory
Summary: Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSD...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-24 21:18 PDT by Daniel Bates
Modified: 2016-03-25 09:05 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2016-03-24 21:19 PDT, Daniel Bates 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-03-24 21:18:43 PDT 
It is sufficient to call webkitdirs::determineXcodeSDK() at the top of script copy-webkitlibraries-to-product-directory to process the --sdk/--device/--ios-simulator command line arguments instead of calling webkitdirs::willUseIOSDeviceSDK() as the latter ultimately calls the former. The purpose of the function webkitdirs::willUseIOSDeviceSDK() is to determine if we will use the iOS device SDK (from parsing the --sdk option or from the presence of the --device option) and as its name implies it returns a boolean value. In contrast, webkitdirs::determineXcodeSDK() does not have a return value and it simply computes and caches the Xcode SDK we will use so that webkitdirs::willUseIOSDeviceSDK() can use this cache.
Comment 1 Daniel Bates 2016-03-24 21:19:34 PDT 
Created attachment 274882 [details]
Patch
Comment 2 Daniel Bates 2016-03-25 09:05:25 PDT 
Committed r198668: <http://trac.webkit.org/changeset/198668>