Bug 155868 - Add a compile time flag for using QTKit
Summary: Add a compile time flag for using QTKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-24 21:02 PDT by Alex Christensen
Modified: 2016-03-25 16:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.19 KB, patch)
2016-03-24 21:04 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (5.54 KB, patch)
2016-03-25 13:37 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-03-24 21:02:58 PDT 
Add a compile time flag for using QTKit
Comment 1 Alex Christensen 2016-03-24 21:04:00 PDT 
Created attachment 274879 [details]
Patch
Comment 2 Daniel Bates 2016-03-24 22:44:13 PDT 
Comment on attachment 274879 [details]
Patch

OK.
Comment 3 Alex Christensen 2016-03-25 10:25:31 PDT 
http://trac.webkit.org/changeset/198673
Comment 4 Alex Christensen 2016-03-25 13:37:13 PDT 
Reopening to attach new patch.
Comment 5 Alex Christensen 2016-03-25 13:37:14 PDT 
Created attachment 274934 [details]
Patch
Comment 6 Alex Christensen 2016-03-25 13:39:10 PDT 
Instead of completely getting rid of Mac's WebVideoFullscreenController implementation, I get rid of just the QTKit parts of it.  This way it compiles all the way.
Comment 7 WebKit Commit Bot 2016-03-25 16:06:08 PDT 
Comment on attachment 274934 [details]
Patch

Clearing flags on attachment: 274934

Committed r198696: <http://trac.webkit.org/changeset/198696>
Comment 8 WebKit Commit Bot 2016-03-25 16:06:11 PDT 
All reviewed patches have been landed.  Closing bug.