Bug 155863 – Migrate admin-regenerate-manifest.js to mocha.js and test v3 UI code

• Status: RESOLVED
• Resolution: FIXED
• Component: Perf Dashboard

[Ryosuke Niwa]

Migrate legacy tests/admin-regenerate-manifest.js to mocha.js,
and test v3 UI code in addition to the server backend.

[Ryosuke Niwa]

Created attachment 274874 [details]
Migrates the test

[Joseph Pecoraro]

Comment on attachment 274874 [details]
Migrates the test

View in context: https://bugs.webkit.org/attachment.cgi?id=274874&action=review

> Websites/perf.webkit.org/public/v3/models/manifest.js:58
> +        }

Nit: Semicolon.

> Websites/perf.webkit.org/public/v3/models/platform.js:20
> +                for (var currentTest = metric.test(); currentTest; currentTest = test.parentTest()) {

This seems super sketchy. The iteration portion of the for loop is always setting the same value... and we just break because we run the loop twice with the same value. Should the iteration portion be "currentTest = currentTest.parentTest()" or could this be written in a clearer way?

[Ryosuke Niwa]

Comment on attachment 274874 [details]
Migrates the test

View in context: https://bugs.webkit.org/attachment.cgi?id=274874&action=review

>> Websites/perf.webkit.org/public/v3/models/platform.js:20
>> +                for (var currentTest = metric.test(); currentTest; currentTest = test.parentTest()) {
> 
> This seems super sketchy. The iteration portion of the for loop is always setting the same value... and we just break because we run the loop twice with the same value. Should the iteration portion be "currentTest = currentTest.parentTest()" or could this be written in a clearer way?

Yup, it's supposed to be "currentTest = currentTest.parentTest()."
Will fix and a test case before landing it.

[Ryosuke Niwa]

Committed r198691: <http://trac.webkit.org/changeset/198691>