Don't hardcode 'Inspector'.
<rdar://problem/25349859>
Created attachment 274868 [details] WIP - needs build system work
Created attachment 274916 [details] Proposed Fix
Attachment 274916 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:46: [CppFrontendDispatcherHeaderGenerator.output_filename] Instance of 'CppFrontendDispatcherHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:53: [CppFrontendDispatcherHeaderGenerator.generate_output] Instance of 'CppFrontendDispatcherHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py:44: [CppAlternateBackendDispatcherHeaderGenerator.output_filename] Instance of 'CppAlternateBackendDispatcherHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py:48: [CppAlternateBackendDispatcherHeaderGenerator.generate_output] Instance of 'CppAlternateBackendDispatcherHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:46: [CppBackendDispatcherHeaderGenerator.output_filename] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:53: [CppBackendDispatcherHeaderGenerator.generate_output] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:46: [CppProtocolTypesHeaderGenerator.output_filename] Instance of 'CppProtocolTypesHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:46: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:51: [CppGenerator.protocol_name] Instance of 'CppGenerator' has no 'model' member [pylint/E1101] [5] Total errors found: 9 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 274916 [details] Proposed Fix pragma once changing some names around seems ok. r=me, but wait for ews Also, this could probably fix the need for my awful hack in http://trac.webkit.org/changeset/198659/trunk/Source/WebKit2/CMakeLists.txt
(In reply to comment #5) > Comment on attachment 274916 [details] > Proposed Fix > > pragma once > changing some names around > seems ok. r=me, but wait for ews > Also, this could probably fix the need for my awful hack in > http://trac.webkit.org/changeset/198659/trunk/Source/WebKit2/CMakeLists.txt If EWS passes, I'll do a partial revert and land it locally. Otherwise I'll add the revert to the next EWS patch.
Committed r198678: <http://trac.webkit.org/changeset/198678>