Bug 155854 – ES6: Implement IsRegExp function and use where needed in String.prototype.* methods

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

https://tc39.github.io/ecma262/#sec-isregexp

[Saam Barati]

Created attachment 274858 [details]
patch

[Saam Barati]

Created attachment 274859 [details]
patch

[Mark Lam]

Comment on attachment 274859 [details]
patch

r=me

[Saam Barati]

Created attachment 274860 [details]
patch

[Saam Barati]

Created attachment 274861 [details]
patch for landing

[Saam Barati]

landed in:
http://trac.webkit.org/changeset/198652

[Darin Adler]

Comment on attachment 274861 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=274861&action=review

> Source/JavaScriptCore/runtime/StringPrototype.cpp:1848


1) "cannot" is a single word, "can not" is incorrect. English is stranger than C++™.
2) We should figure out a consistent style for these error strings. A cleanup for the future.
3) Should this have a period or not?

> Source/JavaScriptCore/runtime/StringPrototype.cpp:1884
> +        return throwVMTypeError(exec, "Argument to String.prototype.endsWith can not be a RegExp.");

Ditto.

[Saam Barati]

(In reply to comment #7)
> Comment on attachment 274861 [details]
> patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274861&action=review
> 
> > Source/JavaScriptCore/runtime/StringPrototype.cpp:1848
> 
> 
> 1) "cannot" is a single word, "can not" is incorrect. English is stranger
> than C++™.
> 2) We should figure out a consistent style for these error strings. A
> cleanup for the future.
> 3) Should this have a period or not?
> 
> > Source/JavaScriptCore/runtime/StringPrototype.cpp:1884
> > +        return throwVMTypeError(exec, "Argument to String.prototype.endsWith can not be a RegExp.");
> 
> Ditto.

Thanks. I will update these.

[Saam Barati]

Big to fix grammar

https://bugs.webkit.org/show_bug.cgi?id=155895