Bug 155845 - Fix internal iOS9 performance regression after r197572
Summary: Fix internal iOS9 performance regression after r197572
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-24 11:33 PDT by Alex Christensen
Modified: 2016-03-24 12:57 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.06 KB, patch)
2016-03-24 11:34 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.10 KB, patch)
2016-03-24 11:43 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-03-24 11:33:01 PDT 
Fix internal iOS9 performance regression after r197572
Comment 1 Alex Christensen 2016-03-24 11:34:47 PDT 
Created attachment 274847 [details]
Patch
Comment 2 Chris Dumez 2016-03-24 11:37:38 PDT 
rdar://problem/25144924
Comment 3 Chris Dumez 2016-03-24 11:38:27 PDT 
Comment on attachment 274847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274847&action=review

> Source/WTF/wtf/Platform.h:554
> +#if USE(APPLE_INTERNAL_SDK) && __IPHONE_OS_VERSION_MIN_REQUIRED <= 90000

how about 9.x ?

You likely want to use < iOS10 instead.
Comment 4 Chris Dumez 2016-03-24 11:39:53 PDT 
Comment on attachment 274847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274847&action=review

>> Source/WTF/wtf/Platform.h:554
>> +#if USE(APPLE_INTERNAL_SDK) && __IPHONE_OS_VERSION_MIN_REQUIRED <= 90000
> 
> how about 9.x ?
> 
> You likely want to use < iOS10 instead.

Can this be just:
if __IPHONE_OS_VERSION_MIN_REQUIRED < 100000
#define USE_CFNETWORK 1
#endif

?
Comment 5 Chris Dumez 2016-03-24 11:41:51 PDT 
(In reply to comment #4)
> Comment on attachment 274847 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274847&action=review
> 
> >> Source/WTF/wtf/Platform.h:554
> >> +#if USE(APPLE_INTERNAL_SDK) && __IPHONE_OS_VERSION_MIN_REQUIRED <= 90000
> > 
> > how about 9.x ?
> > 
> > You likely want to use < iOS10 instead.
> 
> Can this be just:
> if __IPHONE_OS_VERSION_MIN_REQUIRED < 100000
> #define USE_CFNETWORK 1
> #endif
> 
> ?

Actually, previous we had USE(APPLE_INTERNAL_SDK) as condition so I guess we should use:
if USE(APPLE_INTERNAL_SDK) && __IPHONE_OS_VERSION_MIN_REQUIRED < 100000
#define USE_CFNETWORK 1
#endif
Comment 6 Alex Christensen 2016-03-24 11:43:38 PDT 
Created attachment 274848 [details]
Patch
Comment 7 Chris Dumez 2016-03-24 11:49:59 PDT 
Comment on attachment 274848 [details]
Patch

r=me, thanks.
Comment 8 Chris Dumez 2016-03-24 12:56:57 PDT 
Comment on attachment 274848 [details]
Patch

Clearing flags on attachment: 274848

Committed r198641: <http://trac.webkit.org/changeset/198641>
Comment 9 Chris Dumez 2016-03-24 12:57:02 PDT 
All reviewed patches have been landed.  Closing bug.