RESOLVED FIXED 155841
Web Automation: Add commands to compute layout of an element 
https://bugs.webkit.org/show_bug.cgi?id=155841
Summary Web Automation: Add commands to compute layout of an element
Timothy Hatcher
Reported 2016-03-24 10:10:42 PDT
We need a rect and to be able to scroll the element into view first.
Attachments
Patch (16.39 KB, patch)
2016-03-24 10:16 PDT, Timothy Hatcher 		bburg: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-24 10:10:58 PDT
<rdar://problem/25340075>
Timothy Hatcher
Comment 2 2016-03-24 10:16:31 PDT
Created attachment 274840 [details] Patch
Blaze Burg
Comment 3 2016-03-25 17:03:56 PDT
Comment on attachment 274840 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274840&action=review r=me > Source/WebKit2/UIProcess/Automation/Automation.json:256 > + { "name": "useViewportCoordinates", "optional": true, "type": "boolean", "description": "If the result coordinates should be represented as viewport coordinates or not. Defaults to false, which is means coordinates should be represented as page coordinates." } Grammar: 'which is means' For the JSON protocol, I would prefer that this be non-optional and take an enum { PageCoordinates, ViewCoordinates }. It doesn't matter as much for the WK2 message. > Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.cpp:415 > + String frameNotFoundErrorType = Inspector::Protocol::getEnumConstantValue(Inspector::Protocol::Automation::ErrorMessage::FrameNotFound); You can pull these error constants out to the top scope.
Timothy Hatcher
Comment 4 2016-03-28 09:42:14 PDT
https://trac.webkit.org/r198739
Note You need to log in before you can comment on or make changes to this bug.