Bug 155840 - Determine architecture for running jsc stress tests on windows
Summary: Determine architecture for running jsc stress tests on windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-24 09:55 PDT by Bill Ming
Modified: 2016-03-24 22:14 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.00 KB, patch)
2016-03-24 09:58 PDT, Bill Ming
no flags Details | Formatted Diff | Diff
Patch (2.00 KB, patch)
2016-03-24 19:44 PDT, Bill Ming
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bill Ming 2016-03-24 09:55:50 PDT
Currently run-jsc-stress-tests will throw an error saying unable to determine architecture when run on windows.
Comment 1 Bill Ming 2016-03-24 09:58:51 PDT
Created attachment 274839 [details]
Patch
Comment 2 Alex Christensen 2016-03-24 17:15:15 PDT
Comment on attachment 274839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274839&action=review

Looks good to me otherwise. r- because this needs a small fix.

> Tools/Scripts/run-jsc-stress-tests:360
> +    data = f.read(4096)

This is too much.
Comment 3 Bill Ming 2016-03-24 19:44:18 PDT
Created attachment 274875 [details]
Patch
Comment 4 Alex Christensen 2016-03-24 21:26:23 PDT
Comment on attachment 274875 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274875&action=review

> Tools/Scripts/run-jsc-stress-tests:360
> +    data = f.read(1024)

I still think this could be smaller, but I doubt anyone would ever have an executable smaller than 1k.  If they do, we can fix this.
Comment 5 WebKit Commit Bot 2016-03-24 22:14:18 PDT
Comment on attachment 274875 [details]
Patch

Clearing flags on attachment: 274875

Committed r198660: <http://trac.webkit.org/changeset/198660>
Comment 6 WebKit Commit Bot 2016-03-24 22:14:22 PDT
All reviewed patches have been landed.  Closing bug.