Bug 155831 – Add mocha server tests for /api/build-requests

• Status: RESOLVED
• Resolution: FIXED
• Component: Perf Dashboard

[Ryosuke Niwa]

Use mocha.js tests for /api/build-requests.

We'll migrate the existing tests in tests/ once this patch is done.

[Ryosuke Niwa]

Created attachment 274820 [details]
Adds tests

[Chris Dumez]

Comment on attachment 274820 [details]
Adds tests

View in context: https://bugs.webkit.org/attachment.cgi?id=274820&action=review

r=me with fixes

> Websites/perf.webkit.org/server-tests/api-build-requests-tests.js:58
> +    it('should return build requets associated with a given triggerable with appropraite roots and rootSets', function (done) {

Typo appropriate

> Websites/perf.webkit.org/server-tests/resources/test-server.conf:53
> +	AddType application/x-httpd-php .php

Weird indentation

> Websites/perf.webkit.org/server-tests/resources/test-server.js:12
> +let TestSever = (new class TestSever {

Typo testserver

> Websites/perf.webkit.org/server-tests/resources/test-server.js:98
> +            fs.mkdirSync(this._dataDirectory, 0o755);

This permission format looks weird

> Websites/perf.webkit.org/server-tests/resources/test-server.js:162
> +            '-c', `Listen ${port}`,

Why are these all -c ?

[Ryosuke Niwa]

Committed r198642: <http://trac.webkit.org/changeset/198642>

[Ryosuke Niwa]

(In reply to comment #2)
> Comment on attachment 274820 [details]
> Adds tests
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274820&action=review
> 
> r=me with fixes
> 
> > Websites/perf.webkit.org/server-tests/api-build-requests-tests.js:58
> > +    it('should return build requets associated with a given triggerable with appropraite roots and rootSets', function (done) {
> 
> Typo appropriate

Fixed.

> > Websites/perf.webkit.org/server-tests/resources/test-server.conf:53
> > +	AddType application/x-httpd-php .php
> 
> Weird indentation

Fixed.

> > Websites/perf.webkit.org/server-tests/resources/test-server.js:12
> > +let TestSever = (new class TestSever {
> 
> Typo testserver

Fixed.

> > Websites/perf.webkit.org/server-tests/resources/test-server.js:98
> > +            fs.mkdirSync(this._dataDirectory, 0o755);
> 
> This permission format looks weird

o is for octal.

> > Websites/perf.webkit.org/server-tests/resources/test-server.js:162
> > +            '-c', `Listen ${port}`,
> 
> Why are these all -c ?

-c is used to specify a configuration line.