Bug 155830 - [OS X] Overflow:scroll scrollbars do not obey overlay/always-on system preference changes
Summary: [OS X] Overflow:scroll scrollbars do not obey overlay/always-on system prefer...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-23 21:33 PDT by Myles C. Maxfield
Modified: 2016-03-24 19:03 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.10 KB, patch)
2016-03-23 21:56 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-03-23 21:33:20 PDT 
[OS X] Overflow:scroll scrollbars do not obey overlay/always-on system preference changes
Comment 1 Myles C. Maxfield 2016-03-23 21:56:52 PDT 
Created attachment 274816 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-03-23 22:12:42 PDT 
Comment on attachment 274816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274816&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2926
> +        renderer().setNeedsLayout(MarkContainingBlockChain);

Isn't MarkContainingBlockChain the default?

> Source/WebCore/rendering/RenderLayer.cpp:2927
> +        renderer().view().layout();

Ouch. Please don't do a sync layout here.
Comment 3 Myles C. Maxfield 2016-03-24 19:03:26 PDT 
Committed r198656: <http://trac.webkit.org/changeset/198656>