Bug 155827 - webkit-patch failed to open pretty diff on Windows
Summary: webkit-patch failed to open pretty diff on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Windows 10
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-23 19:55 PDT by Bill Ming
Modified: 2016-03-24 10:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.61 KB, patch)
2016-03-23 19:57 PDT, Bill Ming 		no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2016-03-24 00:22 PDT, Bill Ming 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bill Ming 2016-03-23 19:55:39 PDT 
file://%s % urllib.quote(pretty_diff_file.name) will not produce correct file url on windows. Should pathname2url instead.
Comment 1 Bill Ming 2016-03-23 19:57:00 PDT 
Created attachment 274813 [details]
Patch
Comment 2 WebKit Commit Bot 2016-03-23 22:16:58 PDT 
Comment on attachment 274813 [details]
Patch

Clearing flags on attachment: 274813

Committed r198617: <http://trac.webkit.org/changeset/198617>
Comment 3 WebKit Commit Bot 2016-03-23 22:17:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2016-03-23 23:35:58 PDT 
(In reply to comment #2)
> Comment on attachment 274813 [details]
> Patch
> 
> Clearing flags on attachment: 274813
> 
> Committed r198617: <http://trac.webkit.org/changeset/198617>

It broke 7 webkitpy tests.
Comment 5 Bill Ming 2016-03-23 23:37:51 PDT 
I'll have a look
Comment 6 Bill Ming 2016-03-24 00:21:57 PDT 
Reopening to attach new patch.
Comment 7 Bill Ming 2016-03-24 00:22:02 PDT 
Created attachment 274824 [details]
Patch
Comment 8 Bill Ming 2016-03-24 00:23:50 PDT 
All 1452 tests passed
Comment 9 Bill Ming 2016-03-24 00:25:16 PDT 
As the previous patch has already landed, shall I create a new patch for the test case fix?
Comment 10 Alex Christensen 2016-03-24 10:02:55 PDT 
Comment on attachment 274824 [details]
Patch

Usually if something breaks tests, we revert it immediately and land a new patch that doesn't break any tests.  In this case, I just landed your fix in http://trac.webkit.org/changeset/198628