Bug 155818 - bmalloc: Added an Object helper class
Summary: bmalloc: Added an Object helper class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-23 16:45 PDT by Geoffrey Garen
Modified: 2016-03-23 17:12 PDT (History)
1 user (show)

See Also:

Attachments
Patch (15.57 KB, patch)
2016-03-23 16:52 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (15.61 KB, patch)
2016-03-23 16:53 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (16.27 KB, patch)
2016-03-23 17:07 PDT, Geoffrey Garen 		barraclough: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2016-03-23 16:45:42 PDT 
bmalloc: Added an Object helper class
Comment 1 Geoffrey Garen 2016-03-23 16:52:15 PDT 
Created attachment 274794 [details]
Patch
Comment 2 Geoffrey Garen 2016-03-23 16:53:42 PDT 
Created attachment 274795 [details]
Patch
Comment 3 Gavin Barraclough 2016-03-23 17:01:41 PDT 
Comment on attachment 274795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274795&action=review

> Source/bmalloc/bmalloc/SmallChunk.h:47
> +    SmallPage* begin() { return page(sizeof(SmallChunk)); }

I'd suggest not having two ways of doing the same thing (sizeof(SmallChunk) vs m_memory).
Comment 4 Geoffrey Garen 2016-03-23 17:07:00 PDT 
Created attachment 274796 [details]
Patch
Comment 5 Geoffrey Garen 2016-03-23 17:12:04 PDT 
Committed r198606: <http://trac.webkit.org/changeset/198606>