RESOLVED FIXED Bug 155818
bmalloc: Added an Object helper class 
https://bugs.webkit.org/show_bug.cgi?id=155818
Summary bmalloc: Added an Object helper class
Geoffrey Garen
Reported 2016-03-23 16:45:42 PDT
bmalloc: Added an Object helper class
Attachments
Patch (15.57 KB, patch)
2016-03-23 16:52 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (15.61 KB, patch)
2016-03-23 16:53 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (16.27 KB, patch)
2016-03-23 17:07 PDT, Geoffrey Garen 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2016-03-23 16:52:15 PDT
Created attachment 274794 [details] Patch
Geoffrey Garen
Comment 2 2016-03-23 16:53:42 PDT
Created attachment 274795 [details] Patch
Gavin Barraclough
Comment 3 2016-03-23 17:01:41 PDT
Comment on attachment 274795 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274795&action=review > Source/bmalloc/bmalloc/SmallChunk.h:47 > + SmallPage* begin() { return page(sizeof(SmallChunk)); } I'd suggest not having two ways of doing the same thing (sizeof(SmallChunk) vs m_memory).
Geoffrey Garen
Comment 4 2016-03-23 17:07:00 PDT
Created attachment 274796 [details] Patch
Geoffrey Garen
Comment 5 2016-03-23 17:12:04 PDT
Committed r198606: <http://trac.webkit.org/changeset/198606>
Note You need to log in before you can comment on or make changes to this bug.