RESOLVED FIXED 155800
Remove firing assertion when redirecting 
https://bugs.webkit.org/show_bug.cgi?id=155800
Summary Remove firing assertion when redirecting
Alex Christensen
Reported 2016-03-23 11:58:01 PDT
Remove firing assertion when redirecting
Attachments
Patch (1.90 KB, patch)
2016-03-23 12:00 PDT, Alex Christensen 		sam: review+
DetailsFormatted DiffDiff
Archive of layout-test-results from ews113 for mac-yosemite (812.08 KB, application/zip)
2016-03-23 13:06 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-03-23 12:00:27 PDT
Created attachment 274766 [details] Patch
Build Bot
Comment 2 2016-03-23 13:06:38 PDT
Comment on attachment 274766 [details] Patch Attachment 274766 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1027483 New failing tests: imported/w3c/web-platform-tests/streams/readable-streams/general.https.html
Build Bot
Comment 3 2016-03-23 13:06:40 PDT
Created attachment 274769 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Alex Christensen
Comment 4 2016-03-23 13:07:45 PDT
This code is not even compiled on Yosemite. failure unrelated.
Tim Horton
Comment 5 2016-03-23 13:24:44 PDT
Comment on attachment 274766 [details] Patch You should actually figure out what's going on here, because you seem to agree that we really shouldn't be getting here with null networkDataTask, making the assertion not irrelevant.
Alex Christensen
Comment 6 2016-05-02 13:00:14 PDT
Comment on attachment 274766 [details] Patch The load is being "canceled" by the WebProcess, and the NetworkLoad and NetworkDataTask are being destroyed. With NSURLConnection, we stopped getting delegate callbacks once the delegate is destroyed, with NSURLSession we continue getting delegate callbacks because the session's delegate is not destroyed after each load. I think this is correct.
Sam Weinig
Comment 7 2016-05-03 14:19:01 PDT
Comment on attachment 274766 [details] Patch You should remove the assert in didReceiveChallenge as well (and convert it to call NSURLSessionAuthChallengeCancelAuthenticationChallenge instead of NSURLSessionAuthChallengePerformDefaultHandling).
Alex Christensen
Comment 8 2016-05-03 14:50:51 PDT
http://trac.webkit.org/changeset/200388
Note You need to log in before you can comment on or make changes to this bug.