Bug 155800 - Remove firing assertion when redirecting
Summary: Remove firing assertion when redirecting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-23 11:58 PDT by Alex Christensen
Modified: 2016-05-03 14:50 PDT (History)
0 users

See Also:

Attachments
Patch (1.90 KB, patch)
2016-03-23 12:00 PDT, Alex Christensen 		sam: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-yosemite (812.08 KB, application/zip)
2016-03-23 13:06 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-03-23 11:58:01 PDT 
Remove firing assertion when redirecting
Comment 1 Alex Christensen 2016-03-23 12:00:27 PDT 
Created attachment 274766 [details]
Patch
Comment 2 Build Bot 2016-03-23 13:06:38 PDT 
Comment on attachment 274766 [details]
Patch

Attachment 274766 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1027483

New failing tests:
imported/w3c/web-platform-tests/streams/readable-streams/general.https.html
Comment 3 Build Bot 2016-03-23 13:06:40 PDT 
Created attachment 274769 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Alex Christensen 2016-03-23 13:07:45 PDT 
This code is not even compiled on Yosemite.  failure unrelated.
Comment 5 Tim Horton 2016-03-23 13:24:44 PDT 
Comment on attachment 274766 [details]
Patch

You should actually figure out what's going on here, because you seem to agree that we really shouldn't be getting here with null networkDataTask, making the assertion not irrelevant.
Comment 6 Alex Christensen 2016-05-02 13:00:14 PDT 
Comment on attachment 274766 [details]
Patch

The load is being "canceled" by the WebProcess, and the NetworkLoad and NetworkDataTask are being destroyed.  With NSURLConnection, we stopped getting delegate callbacks once the delegate is destroyed, with NSURLSession we continue getting delegate callbacks because the session's delegate is not destroyed after each load.  I think this is correct.
Comment 7 Sam Weinig 2016-05-03 14:19:01 PDT 
Comment on attachment 274766 [details]
Patch

You should remove the assert in didReceiveChallenge as well (and convert it to call NSURLSessionAuthChallengeCancelAuthenticationChallenge instead of NSURLSessionAuthChallengePerformDefaultHandling).
Comment 8 Alex Christensen 2016-05-03 14:50:51 PDT 
http://trac.webkit.org/changeset/200388