155792 – Basic implementation of mpadded

Bug 155792 - Basic implementation of mpadded

Summary: Basic implementation of mpadded

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	MathML (show other bugs)
Version:	WebKit Nightly Build
Hardware:	All All

Importance:	P2 Normal
Assignee:	Frédéric Wang (:fredw)

URL:
Keywords:

Depends on:	153208
Blocks:	mpadded 159620
	Show dependency tree / graph

Reported:	2016-03-23 06:35 PDT by Frédéric Wang (:fredw)
Modified:	2016-07-11 06:40 PDT (History)
CC List:	3 users (show)

See Also:

Attachments
Patch (36.56 KB, patch) 2016-03-23 08:17 PDT, Frédéric Wang (:fredw)	no flags	Details \| Formatted Diff \| Diff
Patch (39.85 KB, patch) 2016-04-26 09:06 PDT, Frédéric Wang (:fredw)	no flags	Details \| Formatted Diff \| Diff
Patch (39.84 KB, patch) 2016-06-25 00:41 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews103 for mac-yosemite (938.87 KB, application/zip) 2016-06-25 01:30 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (803.58 KB, application/zip) 2016-06-25 01:33 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (661.23 KB, application/zip) 2016-06-25 01:39 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-yosemite (1.42 MB, application/zip) 2016-06-25 01:46 PDT, Build Bot	no flags	Details
Patch (39.84 KB, patch) 2016-07-07 15:01 PDT, Frédéric Wang (:fredw)	bfulgham: review+	Details \| Formatted Diff \| Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Frédéric Wang (:fredw) 2016-03-23 06:35:24 PDT

First step to implement mpadded without the pseudo-units values.

Comment 1 Frédéric Wang (:fredw) 2016-03-23 08:17:44 PDT

Created attachment 274750 [details]
Patch

Comment 2 Frédéric Wang (:fredw) 2016-04-26 09:06:17 PDT

Created attachment 277386 [details]
Patch

Comment 3 Frédéric Wang (:fredw) 2016-06-25 00:41:22 PDT

Created attachment 282060 [details]
Patch

Comment 4 Build Bot 2016-06-25 01:30:15 PDT

Comment on attachment 282060 [details]
Patch

Attachment 282060 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1567030

New failing tests:
mathml/presentation/inferred-mrow-stretchy.html

Comment 5 Build Bot 2016-06-25 01:30:18 PDT

Created attachment 282063 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 6 Build Bot 2016-06-25 01:33:38 PDT

Comment on attachment 282060 [details]
Patch

Attachment 282060 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1567034

New failing tests:
mathml/presentation/inferred-mrow-stretchy.html

Comment 7 Build Bot 2016-06-25 01:33:40 PDT

Created attachment 282065 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

Comment 8 Build Bot 2016-06-25 01:39:42 PDT

Comment on attachment 282060 [details]
Patch

Attachment 282060 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1567035

New failing tests:
mathml/presentation/inferred-mrow-stretchy.html

Comment 9 Build Bot 2016-06-25 01:39:45 PDT

Created attachment 282067 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

Comment 10 Build Bot 2016-06-25 01:46:25 PDT

Comment on attachment 282060 [details]
Patch

Attachment 282060 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1567045

New failing tests:
mathml/presentation/inferred-mrow-stretchy.html

Comment 11 Build Bot 2016-06-25 01:46:28 PDT

Created attachment 282069 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 12 Frédéric Wang (:fredw) 2016-07-07 15:01:54 PDT

Created attachment 283057 [details]
Patch

Updating patch...

Comment 13 Brent Fulgham 2016-07-07 16:21:25 PDT

Comment on attachment 283057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283057&action=review

r=me, but please correct the minor issues I pointed out.

> Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp:39
> +    , m_ascent(0)

I don't think this explicit initialization is needed, since the default constructor for LayoutUnit will initialize to zero.

> Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp:51
> +    // We parse it using our the preferred width of the content as the default value.

This reads a little strangely. I think it might need to be "// We parse it using the preferred width of the content as its default value."

> Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp:123
> +    return Optional<int>(static_cast<int>(lroundf(m_ascent)));

We should use:

std::lround(m_ascent)

You might need to #include <cmath>

> Source/WebCore/rendering/mathml/RenderMathMLPadded.h:27
> +#define RenderMathMLPadded_h

#pragma once

Comment 14 Frédéric Wang (:fredw) 2016-07-07 23:17:19 PDT

Committed r202962: <http://trac.webkit.org/changeset/202962>