Bug 155787 - Share style by sharing RenderStyle substructures not the object itself
Summary: Share style by sharing RenderStyle substructures not the object itself
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-23 04:36 PDT by Antti Koivisto
Modified: 2016-03-23 07:30 PDT (History)
5 users (show)

See Also:

Attachments
patch (9.55 KB, patch)
2016-03-23 04:38 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (10.35 KB, patch)
2016-03-23 05:49 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
patch (10.48 KB, patch)
2016-03-23 06:44 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-03-23 04:36:19 PDT 
Current approach where we share RenderStyle objects between elements leads to lot of awkward and bug-prone code. Most of the RenderStyle consists of shareable substructures. It is better to just share those.
Comment 1 Antti Koivisto 2016-03-23 04:38:45 PDT 
Created attachment 274743 [details]
patch
Comment 2 Antti Koivisto 2016-03-23 05:49:42 PDT 
Created attachment 274746 [details]
patch
Comment 3 Andreas Kling 2016-03-23 06:00:12 PDT 
Comment on attachment 274746 [details]
patch

r=me, let's hope this doesn't regress anything, it's so much cleaner.
Comment 4 Antti Koivisto 2016-03-23 06:44:11 PDT 
Created attachment 274748 [details]
patch
Comment 5 Antti Koivisto 2016-03-23 07:30:25 PDT 
https://trac.webkit.org/r198584